'Re: Review Request 127229: Workaround bug 352055'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 127229: Workaround bug 352055
From:       Aleix Pol Gonzalez <aleixpol () kde ! org>
Date:       2016-02-29 23:38:23
Message-ID: 20160229233823.32153.73026 () mimi ! kde ! org
[Download RAW message or body]

--===============5802510122421985425==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127229/#review92955
-----------------------------------------------------------

-1.

You are suggesting us that we don't know what's going on, so we add things that have \
a bigger impact and see if things stick.

Suggestion:
- Run the model with modeltest: https://wiki.qt.io/Model_Test
- Create unit tests.

- Aleix Pol Gonzalez

On Feb. 29, 2016, 11:16 p.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127229/
> -----------------------------------------------------------
> 
> (Updated Feb. 29, 2016, 11:16 p.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Bugs: 352055
> https://bugs.kde.org/show_bug.cgi?id=352055
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> From my debug, the real problem is that the model value in qml some times can have \
> wrong value. When there is the "empty" space in systray, model.index obtained from \
> delegate is -1 and no any other data is available, which should never happens. 
> This is obviously a bug in Qt.. but unfortunately I have no simple test case to \
> reproduce it. 
> 
> Diffs
> -----
> 
> applets/systemtray/plugin/tasklistmodel.cpp 1fa306c 
> 
> Diff: https://git.reviewboard.kde.org/r/127229/diff/
> 
> 
> Testing
> -------
> 
> Works for me at least.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
> 

--===============5802510122421985425==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/127229/">https://git.reviewboard.kde.org/r/127229/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">-1.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">You are suggesting us that we don't know what's going \
on, so we add things that have a bigger impact and see if things stick.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
                inherit;">Suggestion:
- Run the model with modeltest: https://wiki.qt.io/Model_Test
- Create unit tests.</p></pre>
 <br />

<p>- Aleix Pol Gonzalez</p>

<br />
<p>On February 29th, 2016, 11:16 p.m. CET, Xuetian Weng wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma and Marco Martin.</div>
<div>By Xuetian Weng.</div>

<p style="color: grey;"><i>Updated Feb. 29, 2016, 11:16 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://bugs.kde.org/show_bug.cgi?id=352055">352055</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">From my debug, the real problem is that the model \
value in qml some times can have wrong value. When there is the "empty" space in \
systray, model.index obtained from delegate is -1 and no any other data is available, \
which should never happens.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">This is obviously a bug in Qt.. but \
unfortunately I have no simple test case to reproduce it.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Works for me at least.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/systemtray/plugin/tasklistmodel.cpp <span style="color: \
grey">(1fa306c)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/127229/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============5802510122421985425==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 