From kde-panel-devel Mon Feb 29 23:38:23 2016 From: Aleix Pol Gonzalez Date: Mon, 29 Feb 2016 23:38:23 +0000 To: kde-panel-devel Subject: Re: Review Request 127229: Workaround bug 352055 Message-Id: <20160229233823.32153.73026 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=145678912230286 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============8978385574771683520==" --===============8978385574771683520== Content-Type: multipart/alternative; boundary="===============5802510122421985425==" --===============5802510122421985425== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127229/#review92955 ----------------------------------------------------------- -1. You are suggesting us that we don't know what's going on, so we add things that have a bigger impact and see if things stick. Suggestion: - Run the model with modeltest: https://wiki.qt.io/Model_Test - Create unit tests. - Aleix Pol Gonzalez On Feb. 29, 2016, 11:16 p.m., Xuetian Weng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127229/ > ----------------------------------------------------------- > > (Updated Feb. 29, 2016, 11:16 p.m.) > > > Review request for Plasma and Marco Martin. > > > Bugs: 352055 > https://bugs.kde.org/show_bug.cgi?id=352055 > > > Repository: plasma-workspace > > > Description > ------- > > From my debug, the real problem is that the model value in qml some times can have wrong value. When there is the "empty" space in systray, model.index obtained from delegate is -1 and no any other data is available, which should never happens. > > This is obviously a bug in Qt.. but unfortunately I have no simple test case to reproduce it. > > > Diffs > ----- > > applets/systemtray/plugin/tasklistmodel.cpp 1fa306c > > Diff: https://git.reviewboard.kde.org/r/127229/diff/ > > > Testing > ------- > > Works for me at least. > > > Thanks, > > Xuetian Weng > > --===============5802510122421985425== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127229/

-1.

You are suggesting us that we don't know what's going on, so we add things that have a bigger impact and see if things stick.

Suggestion: - Run the model with modeltest: https://wiki.qt.io/Model_Test - Create unit tests.

- Aleix Pol Gonzalez

On February 29th, 2016, 11:16 p.m. CET, Xuetian Weng wrote:

Review request for Plasma and Marco Martin.

By Xuetian Weng.

Updated Feb. 29, 2016, 11:16 p.m.

Bugs: 352055

Repository: plasma-workspace

Description

From my debug, the real problem is that the model value in qml some times can have wrong value. When there is the "empty" space in systray, model.index obtained from delegate is -1 and no any other data is available, which should never happens.

This is obviously a bug in Qt.. but unfortunately I have no simple test case to reproduce it.

Testing

Works for me at least.

Diffs

applets/systemtray/plugin/tasklistmodel.cpp (1fa306c)

--===============5802510122421985425==-- --===============8978385574771683520== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============8978385574771683520==--