[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 127197: [kcm_colors] Port away from KDELibs4Support
From: Anthony Fieroni <bvbfan () abv ! bg>
Date: 2016-02-29 19:36:25
Message-ID: 20160229193625.32153.18727 () mimi ! kde ! org
[Download RAW message or body]
--===============2528328669110118043==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127197/
-----------------------------------------------------------
(Updated Фев. 29, 2016, 9:36 след обяд)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks, Plasma, David Edmundson, David Faure, \
Hugo Parente Lima, and Thomas Lübking.
Repository: plasma-desktop
Description
-------
Start porting to find leaks on X in radeon driver.
Diffs
-----
kcms/colors/CMakeLists.txt f02e0eb
kcms/colors/colorscm.h 8e74e8a
kcms/colors/colorscm.cpp f3c4f05
Diff: https://git.reviewboard.kde.org/r/127197/diff/
Testing
-------
1. Open dolphin, kate, etc...
2. kcmschell5 colors
3. Apply color scheme
4. Extremly leak on X
The bug is in this peace of code
QDBusMessage message = \
QDBusMessage::createSignal(QStringLiteral("/KGlobalSettings"), \
QStringLiteral("org.kde.KGlobalSettings"), QStringLiteral("notifyChange") \
); QList<QVariant> args;
args.append(0);//previous KGlobalSettings::PaletteChanged. This is now \
private API in khintsettings args.append(0);//unused in palette changed \
but needed for the DBus signature message.setArguments(args);
QDBusConnection::sessionBus().send(message);
File Attachments
----------------
Screenshot_20160227_102609.png
https://git.reviewboard.kde.org/media/uploaded/files/2016/02/27/a23bfdad-7465-422e-9cef-25fe7991e795__Screenshot_20160227_102609.png
Thanks,
Anthony Fieroni
--===============2528328669110118043==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: \
1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127197/">https://git.reviewboard.kde.org/r/127197/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px \
gray solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" \
style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: \
6px; -webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks, Plasma, David Edmundson, David \
Faure, Hugo Parente Lima, and Thomas Lübking.</div> <div>By Anthony \
Fieroni.</div>
<p style="color: grey;"><i>Updated Фев. 29, 2016, 9:36 след \
обяд</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Start porting to find leaks \
on X in radeon driver.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><ol style="padding: 0;text-rendering: inherit;margin: 0 0 0 \
2em;line-height: inherit;white-space: normal;"> <li style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">Open dolphin, kate, etc...</li> <li style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">kcmschell5 colors</li> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">Apply color \
scheme</li> <li style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">Extremly leak on X The bug is \
in this peace of code QDBusMessage message = \
QDBusMessage::createSignal(QStringLiteral("/KGlobalSettings"), \
QStringLiteral("org.kde.KGlobalSettings"), QStringLiteral("notifyChange") \
); QList<QVariant> args;
args.append(0);//previous KGlobalSettings::PaletteChanged. This is now \
private API in khintsettings args.append(0);//unused in palette changed \
but needed for the DBus signature message.setArguments(args);
QDBusConnection::sessionBus().send(message);</li>
</ol></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>kcms/colors/CMakeLists.txt <span style="color: \
grey">(f02e0eb)</span></li>
<li>kcms/colors/colorscm.h <span style="color: grey">(8e74e8a)</span></li>
<li>kcms/colors/colorscm.cpp <span style="color: \
grey">(f3c4f05)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127197/diff/" \
style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File \
Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/02/2 \
7/a23bfdad-7465-422e-9cef-25fe7991e795__Screenshot_20160227_102609.png">Screenshot_20160227_102609.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2528328669110118043==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic