From kde-panel-devel Mon Feb 29 19:36:25 2016 From: Anthony Fieroni Date: Mon, 29 Feb 2016 19:36:25 +0000 To: kde-panel-devel Subject: Re: Review Request 127197: [kcm_colors] Port away from KDELibs4Support Message-Id: <20160229193625.32153.18727 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=145677462125232 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============0699162801646200775==" --===============0699162801646200775== Content-Type: multipart/alternative; boundary="===============2528328669110118043==" --===============2528328669110118043== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127197/ ----------------------------------------------------------- (Updated Фев. 29, 2016, 9:36 след обяд) Status ------ This change has been marked as submitted. Review request for KDE Frameworks, Plasma, David Edmundson, David Faure, Hugo Parente Lima, and Thomas Lübking. Repository: plasma-desktop Description ------- Start porting to find leaks on X in radeon driver. Diffs ----- kcms/colors/CMakeLists.txt f02e0eb kcms/colors/colorscm.h 8e74e8a kcms/colors/colorscm.cpp f3c4f05 Diff: https://git.reviewboard.kde.org/r/127197/diff/ Testing ------- 1. Open dolphin, kate, etc... 2. kcmschell5 colors 3. Apply color scheme 4. Extremly leak on X The bug is in this peace of code QDBusMessage message = QDBusMessage::createSignal(QStringLiteral("/KGlobalSettings"), QStringLiteral("org.kde.KGlobalSettings"), QStringLiteral("notifyChange") ); QList args; args.append(0);//previous KGlobalSettings::PaletteChanged. This is now private API in khintsettings args.append(0);//unused in palette changed but needed for the DBus signature message.setArguments(args); QDBusConnection::sessionBus().send(message); File Attachments ---------------- Screenshot_20160227_102609.png https://git.reviewboard.kde.org/media/uploaded/files/2016/02/27/a23bfdad-7465-422e-9cef-25fe7991e795__Screenshot_20160227_102609.png Thanks, Anthony Fieroni --===============2528328669110118043== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127197/

This change has been marked as submitted.

Review request for KDE Frameworks, Plasma, David Edmundson, David Faure, Hugo Parente Lima, and Thomas Lübking.
By Anthony Fieroni.

Updated Фев. 29, 2016, 9:36 след обяд

Repository: plasma-desktop

Description 

Start porting to find leaks on X in radeon driver.

Testing 

    

  1. Open dolphin, kate, etc...
    2. 

  2. kcmschell5 colors
    3. 

  3. Apply color scheme
    4. 

  4. Extremly leak on X
The bug is in this peace of code
QDBusMessage message = QDBusMessage::createSignal(QStringLiteral("/KGlobalSettings"), QStringLiteral("org.kde.KGlobalSettings"), QStringLiteral("notifyChange") );
    QList<QVariant> args;
    args.append(0);//previous KGlobalSettings::PaletteChanged. This is now private API in khintsettings
    args.append(0);//unused in palette changed but needed for the DBus signature
    message.setArguments(args);
    QDBusConnection::sessionBus().send(message);
    5.

Diffs

  • kcms/colors/CMakeLists.txt (f02e0eb)
  • kcms/colors/colorscm.h (8e74e8a)
  • kcms/colors/colorscm.cpp (f3c4f05)

View Diff

File Attachments

  • Screenshot_20160227_102609.png
    		•
    --===============2528328669110118043==-- --===============0699162801646200775== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============0699162801646200775==--