[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 127086: Raise the required CMake version to 3.4.0
From: Hrvoje Senjan <hrvoje.senjan () gmail ! com>
Date: 2016-02-29 17:19:04
Message-ID: 20160229171904.32153.99481 () mimi ! kde ! org
[Download RAW message or body]
--===============2444235981455165144==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127086/#review92924
-----------------------------------------------------------
Isn't raising the version a bit of a overkill for a module that only indicates \
RUNTIME requirement? Another way is to check for ISOcodes only with cmake 3.4.
- Hrvoje Senjan
On Feb. 16, 2016, 12:13 p.m., Elias Probst wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127086/
> -----------------------------------------------------------
>
> (Updated Feb. 16, 2016, 12:13 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> Since fea67bd2 plasma-workspace requires CMake >= 3.4.0 as
> pkg_get_variable used in cmake/FindIsoCodes.cmake isn't available in previous
> releases.
>
>
> Diffs
> -----
>
> CMakeLists.txt c2debaa3aeb24b4da9918642b8931002c205d228
>
> Diff: https://git.reviewboard.kde.org/r/127086/diff/
>
>
> Testing
> -------
>
> Updated from CMake 3.3.1 to 3.4.3 and cmake/FindIsoCodes.cmake succeeded.
>
>
> Thanks,
>
> Elias Probst
>
>
--===============2444235981455165144==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127086/">https://git.reviewboard.kde.org/r/127086/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Isn't \
raising the version a bit of a overkill for a module that only indicates RUNTIME \
requirement? Another way is to check for ISOcodes only with cmake 3.4.</p></pre> <br \
/>
<p>- Hrvoje Senjan</p>
<br />
<p>On February 16th, 2016, 12:13 p.m. CET, Elias Probst wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Elias Probst.</div>
<p style="color: grey;"><i>Updated Feb. 16, 2016, 12:13 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Since fea67bd2 plasma-workspace requires CMake >= 3.4.0 as \
pkg_get_variable used in cmake/FindIsoCodes.cmake isn't available in previous \
releases.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Updated from CMake 3.3.1 to 3.4.3 and \
cmake/FindIsoCodes.cmake succeeded.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: \
grey">(c2debaa3aeb24b4da9918642b8931002c205d228)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127086/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2444235981455165144==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic