From kde-panel-devel Mon Feb 29 17:19:04 2016 From: Hrvoje Senjan Date: Mon, 29 Feb 2016 17:19:04 +0000 To: kde-panel-devel Subject: Re: Review Request 127086: Raise the required CMake version to 3.4.0 Message-Id: <20160229171904.32153.99481 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=145676635722360 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============8733317854946092461==" --===============8733317854946092461== Content-Type: multipart/alternative; boundary="===============2444235981455165144==" --===============2444235981455165144== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127086/#review92924 ----------------------------------------------------------- Isn't raising the version a bit of a overkill for a module that only indicates RUNTIME requirement? Another way is to check for ISOcodes only with cmake 3.4. - Hrvoje Senjan On Feb. 16, 2016, 12:13 p.m., Elias Probst wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127086/ > ----------------------------------------------------------- > > (Updated Feb. 16, 2016, 12:13 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > Since fea67bd2 plasma-workspace requires CMake >= 3.4.0 as > pkg_get_variable used in cmake/FindIsoCodes.cmake isn't available in previous > releases. > > > Diffs > ----- > > CMakeLists.txt c2debaa3aeb24b4da9918642b8931002c205d228 > > Diff: https://git.reviewboard.kde.org/r/127086/diff/ > > > Testing > ------- > > Updated from CMake 3.3.1 to 3.4.3 and cmake/FindIsoCodes.cmake succeeded. > > > Thanks, > > Elias Probst > > --===============2444235981455165144== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127086/

Isn't raising the version a bit of a overkill for a module that only indicates RUNTIME requirement? Another way is to check for ISOcodes only with cmake 3.4.

- Hrvoje Senjan

On February 16th, 2016, 12:13 p.m. CET, Elias Probst wrote:

Review request for Plasma.

By Elias Probst.

Updated Feb. 16, 2016, 12:13 p.m.

Repository: plasma-workspace

Description

Since fea67bd2 plasma-workspace requires CMake >= 3.4.0 as
pkg_get_variable used in cmake/FindIsoCodes.cmake isn't available in previous
releases.

Testing

Updated from CMake 3.3.1 to 3.4.3 and cmake/FindIsoCodes.cmake succeeded.

Diffs

CMakeLists.txt (c2debaa3aeb24b4da9918642b8931002c205d228)

View Diff

--===============2444235981455165144==-- --===============8733317854946092461== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============8733317854946092461==--