[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 127103: Add autotests for IconItem
From: Weng Xuetian <wengxt () gmail ! com>
Date: 2016-02-27 23:18:20
Message-ID: CAKiDycH19UKOFYzUsC+W94s009vLbNcJARBenBGrafFXen5zZQ () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
pixelColor is only in Qt 5.6.
Does plasma-frameworks depend on Qt 5.6 right now?
On Sat, Feb 27, 2016 at 12:25 PM, David Rosca <nowrep@gmail.com> wrote:
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127103/
> This change has been marked as submitted.
> Review request for Plasma.
> By David Rosca.
>
> *Updated Feb. 27, 2016, 8:25 p.m.*
> Changes
>
> Submitted with commit 526915895b243ecf96298c9175a24dbf4b153393 by David Rosca to branch \
> master.
> *Repository: * plasma-framework
> Description
>
> Add some tests for IconItem.
> Also found one issue in animation when quickly changing source, first frame will be rendered \
> with wrong icon.
> Testing
>
> Tests pass localy, I used only icons that are shipped with plasma-framework breeze theme so \
> it should work on CI too.
> There is also test that checks if animation is not running after the item was hidden. This \
> needs https://git.reviewboard.kde.org/r/122859/, so this should land only after that.
> Diffs
>
> - autotests/CMakeLists.txt (258adb8)
> - autotests/data/icons/hicolor/22x22/apps/bug359388.svg (PRE-CREATION)
> - autotests/data/view.qml (PRE-CREATION)
> - autotests/iconitemtest.h (PRE-CREATION)
> - autotests/iconitemtest.cpp (PRE-CREATION)
> - src/declarativeimports/core/iconitem.cpp (085f284)
>
> View Diff <https://git.reviewboard.kde.org/r/127103/diff/>
>
> _______________________________________________
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
>
[Attachment #5 (text/html)]
<div dir="ltr"><div>pixelColor is only in Qt 5.6.<br><br></div>Does plasma-frameworks depend on \
Qt 5.6 right now?<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Feb \
27, 2016 at 12:25 PM, David Rosca <span dir="ltr"><<a href="mailto:nowrep@gmail.com" \
target="_blank">nowrep@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" \
style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
<div style="font-family:Verdana,Arial,Helvetica,Sans-Serif"><span class="">
<table style="border:1px #c9c399 solid;border-radius:6px" bgcolor="#f9f3c9" cellpadding="12" \
width="100%"> <tbody><tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127103/" \
target="_blank">https://git.reviewboard.kde.org/r/127103/</a> </td>
</tr>
</tbody></table>
<br>
</span><table style="border:1px gray solid;border-radius:6px" bgcolor="#e0e0e0" \
cellpadding="12" width="100%"> <tbody><tr>
<td>
<h1 style="margin:0;padding:0;font-size:10pt">This change has been marked as submitted.</h1>
</td>
</tr>
</tbody></table>
<br>
<table style="border:1px #888a85 solid;border-radius:6px" bgcolor="#fefadf" cellpadding="12" \
cellspacing="0" width="100%"> <tbody><tr>
<td><span class="">
<div>Review request for Plasma.</div>
<div>By David Rosca.</div>
</span><p style="color:grey"><i>Updated Feb. 27, 2016, 8:25 p.m.</i></p>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Changes</h1>
<table style="border:1px solid #b8b5a0" bgcolor="#ffffff" cellpadding="10" cellspacing="0" \
width="100%"> <tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Submitted \
with commit 526915895b243ecf96298c9175a24dbf4b153393 by David Rosca to branch master.</pre> \
</td> </tr>
</tbody></table><span class="">
<div style="margin-top:1.5em">
<b style="color:#575012;font-size:10pt">Repository: </b>
plasma-framework
</div>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Description </h1>
<table style="border:1px solid #b8b5a0" bgcolor="#ffffff" cellpadding="10" cellspacing="0" \
width="100%"> <tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word"><p \
style="padding:0;margin:0;line-height:inherit;white-space:inherit">Add some tests for IconItem. \
Also found one issue in animation when quickly changing source, first frame will be rendered \
with wrong icon.</p></pre> </td>
</tr>
</tbody></table>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Testing </h1>
<table style="border:1px solid #b8b5a0" bgcolor="#ffffff" cellpadding="10" cellspacing="0" \
width="100%"> <tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word"><p \
style="padding:0;margin:0;line-height:inherit;white-space:inherit">Tests pass localy, I used \
only icons that are shipped with plasma-framework breeze theme so it should work on CI too.</p> \
<p style="padding:0;margin:0;line-height:inherit;white-space:inherit">There is also test that \
checks if animation is not running after the item was hidden. This needs <a \
href="https://git.reviewboard.kde.org/r/122859/" \
target="_blank">https://git.reviewboard.kde.org/r/122859/</a>, so this should land only after \
that.</p></pre> </td>
</tr>
</tbody></table>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Diffs </h1>
<ul style="margin-left:3em;padding-left:0">
<li>autotests/CMakeLists.txt <span style="color:grey">(258adb8)</span></li>
<li>autotests/data/icons/hicolor/22x22/apps/bug359388.svg <span \
style="color:grey">(PRE-CREATION)</span></li>
<li>autotests/data/view.qml <span style="color:grey">(PRE-CREATION)</span></li>
<li>autotests/iconitemtest.h <span style="color:grey">(PRE-CREATION)</span></li>
<li>autotests/iconitemtest.cpp <span style="color:grey">(PRE-CREATION)</span></li>
<li>src/declarativeimports/core/iconitem.cpp <span style="color:grey">(085f284)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127103/diff/" style="margin-left:3em" \
target="_blank">View Diff</a></p>
</span></td>
</tr>
</tbody></table>
</div>
</div>
<br>_______________________________________________<br>
Plasma-devel mailing list<br>
<a href="mailto:Plasma-devel@kde.org">Plasma-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/plasma-devel" rel="noreferrer" \
target="_blank">https://mail.kde.org/mailman/listinfo/plasma-devel</a><br> \
<br></blockquote></div><br></div>
[Attachment #6 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic