--===============2221024513203410712==
Content-Type: multipart/alternative; boundary=089e01538c3ca92c36052cc8a1f9

--089e01538c3ca92c36052cc8a1f9
Content-Type: text/plain; charset=UTF-8

pixelColor is only in Qt 5.6.

Does plasma-frameworks depend on Qt 5.6 right now?

On Sat, Feb 27, 2016 at 12:25 PM, David Rosca <nowrep@gmail.com> wrote:

> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127103/
> This change has been marked as submitted.
> Review request for Plasma.
> By David Rosca.
>
> *Updated Feb. 27, 2016, 8:25 p.m.*
> Changes
>
> Submitted with commit 526915895b243ecf96298c9175a24dbf4b153393 by David Rosca to branch master.
>
> *Repository: * plasma-framework
> Description
>
> Add some tests for IconItem.
> Also found one issue in animation when quickly changing source, first frame will be rendered with wrong icon.
>
> Testing
>
> Tests pass localy, I used only icons that are shipped with plasma-framework breeze theme so it should work on CI too.
>
> There is also test that checks if animation is not running after the item was hidden. This needs https://git.reviewboard.kde.org/r/122859/, so this should land only after that.
>
> Diffs
>
>    - autotests/CMakeLists.txt (258adb8)
>    - autotests/data/icons/hicolor/22x22/apps/bug359388.svg (PRE-CREATION)
>    - autotests/data/view.qml (PRE-CREATION)
>    - autotests/iconitemtest.h (PRE-CREATION)
>    - autotests/iconitemtest.cpp (PRE-CREATION)
>    - src/declarativeimports/core/iconitem.cpp (085f284)
>
> View Diff <https://git.reviewboard.kde.org/r/127103/diff/>
>
> _______________________________________________
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
>

--089e01538c3ca92c36052cc8a1f9
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>pixelColor is only in Qt 5.6.<br><br></div>Does plasm=
a-frameworks depend on Qt 5.6 right now?<br></div><div class=3D"gmail_extra=
"><br><div class=3D"gmail_quote">On Sat, Feb 27, 2016 at 12:25 PM, David Ro=
sca <span dir=3D"ltr">&lt;<a href=3D"mailto:nowrep@gmail.com" target=3D"_bl=
ank">nowrep@gmail.com</a>&gt;</span> wrote:<br><blockquote class=3D"gmail_q=
uote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1e=
x">



 <div>
  <div style=3D"font-family:Verdana,Arial,Helvetica,Sans-Serif"><span class=
=3D"">
   <table style=3D"border:1px #c9c399 solid;border-radius:6px" bgcolor=3D"#=
f9f3c9" cellpadding=3D"12" width=3D"100%">
    <tbody><tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href=3D"https://git.reviewboard.kde.org/r/127103/" target=3D"_blan=
k">https://git.reviewboard.kde.org/r/127103/</a>
     </td>
    </tr>
   </tbody></table>
   <br>



</span><table style=3D"border:1px gray solid;border-radius:6px" bgcolor=3D"=
#e0e0e0" cellpadding=3D"12" width=3D"100%">
 <tbody><tr>
  <td>
   <h1 style=3D"margin:0;padding:0;font-size:10pt">This change has been mar=
ked as submitted.</h1>
  </td>
 </tr>
</tbody></table>
<br>


<table style=3D"border:1px #888a85 solid;border-radius:6px" bgcolor=3D"#fef=
adf" cellpadding=3D"12" cellspacing=3D"0" width=3D"100%">
 <tbody><tr>
  <td><span class=3D"">

<div>Review request for Plasma.</div>
<div>By David Rosca.</div>


</span><p style=3D"color:grey"><i>Updated Feb. 27, 2016, 8:25 p.m.</i></p>



<h1 style=3D"color:#575012;font-size:10pt;margin-top:1.5em">Changes</h1>
<table style=3D"border:1px solid #b8b5a0" bgcolor=3D"#ffffff" cellpadding=
=3D"10" cellspacing=3D"0" width=3D"100%">
 <tbody><tr>
  <td>
   <pre style=3D"margin:0;padding:0;white-space:pre-wrap;white-space:-moz-p=
re-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word"=
>Submitted with commit 526915895b243ecf96298c9175a24dbf4b153393 by David Ro=
sca to branch master.</pre>
  </td>
 </tr>
</tbody></table><span class=3D"">







<div style=3D"margin-top:1.5em">
 <b style=3D"color:#575012;font-size:10pt">Repository: </b>
plasma-framework
</div>


<h1 style=3D"color:#575012;font-size:10pt;margin-top:1.5em">Description </h=
1>
 <table style=3D"border:1px solid #b8b5a0" bgcolor=3D"#ffffff" cellpadding=
=3D"10" cellspacing=3D"0" width=3D"100%">
 <tbody><tr>
  <td>
   <pre style=3D"margin:0;padding:0;white-space:pre-wrap;white-space:-moz-p=
re-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word"=
><p style=3D"padding:0;margin:0;line-height:inherit;white-space:inherit">Ad=
d some tests for IconItem.
Also found one issue in animation when quickly changing source, first frame=
 will be rendered with wrong icon.</p></pre>
  </td>
 </tr>
</tbody></table>


<h1 style=3D"color:#575012;font-size:10pt;margin-top:1.5em">Testing </h1>
<table style=3D"border:1px solid #b8b5a0" bgcolor=3D"#ffffff" cellpadding=
=3D"10" cellspacing=3D"0" width=3D"100%">
 <tbody><tr>
  <td>
   <pre style=3D"margin:0;padding:0;white-space:pre-wrap;white-space:-moz-p=
re-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word"=
><p style=3D"padding:0;margin:0;line-height:inherit;white-space:inherit">Te=
sts pass localy, I used only icons that are shipped with plasma-framework b=
reeze theme so it should work on CI too.</p>
<p style=3D"padding:0;margin:0;line-height:inherit;white-space:inherit">The=
re is also test that checks if animation is not running after the item was =
hidden. This needs <a href=3D"https://git.reviewboard.kde.org/r/122859/" ta=
rget=3D"_blank">https://git.reviewboard.kde.org/r/122859/</a>, so this shou=
ld land only after that.</p></pre>
  </td>
 </tr>
</tbody></table>


<h1 style=3D"color:#575012;font-size:10pt;margin-top:1.5em">Diffs </h1>
<ul style=3D"margin-left:3em;padding-left:0">

 <li>autotests/CMakeLists.txt <span style=3D"color:grey">(258adb8)</span></=
li>

 <li>autotests/data/icons/hicolor/22x22/apps/bug359388.svg <span style=3D"c=
olor:grey">(PRE-CREATION)</span></li>

 <li>autotests/data/view.qml <span style=3D"color:grey">(PRE-CREATION)</spa=
n></li>

 <li>autotests/iconitemtest.h <span style=3D"color:grey">(PRE-CREATION)</sp=
an></li>

 <li>autotests/iconitemtest.cpp <span style=3D"color:grey">(PRE-CREATION)</=
span></li>

 <li>src/declarativeimports/core/iconitem.cpp <span style=3D"color:grey">(0=
85f284)</span></li>

</ul>

<p><a href=3D"https://git.reviewboard.kde.org/r/127103/diff/" style=3D"marg=
in-left:3em" target=3D"_blank">View Diff</a></p>






  </span></td>
 </tr>
</tbody></table>



  </div>
 </div>


<br>_______________________________________________<br>
Plasma-devel mailing list<br>
<a href=3D"mailto:Plasma-devel@kde.org">Plasma-devel@kde.org</a><br>
<a href=3D"https://mail.kde.org/mailman/listinfo/plasma-devel" rel=3D"noref=
errer" target=3D"_blank">https://mail.kde.org/mailman/listinfo/plasma-devel=
</a><br>
<br></blockquote></div><br></div>

--089e01538c3ca92c36052cc8a1f9--

--===============2221024513203410712==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl
dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y
Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo=

--===============2221024513203410712==--