'Review Request 126938: [Widget Explorer] Show desktop on dragging widget'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Review Request 126938: [Widget Explorer] Show desktop on dragging widget
From:       Kai Uwe Broulik <kde () privat ! broulik ! de>
Date:       2016-01-31 14:51:15
Message-ID: 20160131145115.17778.60286 () mimi ! kde ! org
[Download RAW message or body]

--===============3585834072453930681==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126938/
-----------------------------------------------------------

Review request for Plasma and KDE Usability.

Bugs: 327530
    https://bugs.kde.org/show_bug.cgi?id=327530

Repository: plasma-desktop

Description
-------

When starting to drag a widget, show desktop mode is enabled causing all windows but \
the widget explorer to disappear.

Windows are only restored when widget explorer closes, not as soon as you drop it, so \
you can see where you dropped the widget and configure it right away also.

Diffs
-----

  desktoppackage/contents/explorer/AppletDelegate.qml c315b4c 
  desktoppackage/contents/explorer/WidgetExplorer.qml 90e84d3 

Diff: https://git.reviewboard.kde.org/r/126938/diff/

Testing
-------

Opened widget explorer from my panel, started dragging a widget, windows disappeared, \
dropped on desktop, closed widget explorer, windows re-appeared.

There's a glitch when you drop a widget and then open its config dialog, widget \
explorer does not automatically hide thus keeping show desktop enabled and the config \
dialog disappears immediately after it was shown.

I guess this is because hide on window deactivate in Dialog checks for whether I \
tapped a containment, which I did, and then keeps the dialog open.

Thanks,

Kai Uwe Broulik

--===============3585834072453930681==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126938/">https://git.reviewboard.kde.org/r/126938/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma and KDE Usability.</div>
<div>By Kai Uwe Broulik.</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://bugs.kde.org/show_bug.cgi?id=327530">327530</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">When starting to drag a widget, show desktop mode is \
enabled causing all windows but the widget explorer to disappear.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Windows are only restored when widget explorer closes, not as soon as you \
drop it, so you can see where you dropped the widget and configure it right away \
also.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Opened widget explorer from my panel, started dragging \
a widget, windows disappeared, dropped on desktop, closed widget explorer, windows \
re-appeared.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">There's a glitch when you drop a widget and then open \
its config dialog, widget explorer does not automatically hide thus keeping show \
desktop enabled and the config dialog disappears immediately after it was shown.</p> \
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I guess this is because hide on window deactivate in \
Dialog checks for whether I tapped a containment, which I did, and then keeps the \
dialog open.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>desktoppackage/contents/explorer/AppletDelegate.qml <span style="color: \
grey">(c315b4c)</span></li>

 <li>desktoppackage/contents/explorer/WidgetExplorer.qml <span style="color: \
grey">(90e84d3)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126938/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============3585834072453930681==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 