--===============2965808848359963116== Content-Type: multipart/alternative; boundary="===============3585834072453930681==" --===============3585834072453930681== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126938/ ----------------------------------------------------------- Review request for Plasma and KDE Usability. Bugs: 327530 https://bugs.kde.org/show_bug.cgi?id=327530 Repository: plasma-desktop Description ------- When starting to drag a widget, show desktop mode is enabled causing all windows but the widget explorer to disappear. Windows are only restored when widget explorer closes, not as soon as you drop it, so you can see where you dropped the widget and configure it right away also. Diffs ----- desktoppackage/contents/explorer/AppletDelegate.qml c315b4c desktoppackage/contents/explorer/WidgetExplorer.qml 90e84d3 Diff: https://git.reviewboard.kde.org/r/126938/diff/ Testing ------- Opened widget explorer from my panel, started dragging a widget, windows disappeared, dropped on desktop, closed widget explorer, windows re-appeared. There's a glitch when you drop a widget and then open its config dialog, widget explorer does not automatically hide thus keeping show desktop enabled and the config dialog disappears immediately after it was shown. I guess this is because hide on window deactivate in Dialog checks for whether I tapped a containment, which I did, and then keeps the dialog open. Thanks, Kai Uwe Broulik --===============3585834072453930681== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126938/

Review request for Plasma and KDE Usability.

By Kai Uwe Broulik.

Bugs: 327530

Repository: plasma-desktop

Description

When starting to drag a widget, show desktop mode is enabled causing all windows but the widget explorer to disappear.

Windows are only restored when widget explorer closes, not as soon as you drop it, so you can see where you dropped the widget and configure it right away also.

Testing

Opened widget explorer from my panel, started dragging a widget, windows disappeared, dropped on desktop, closed widget explorer, windows re-appeared.

There's a glitch when you drop a widget and then open its config dialog, widget explorer does not automatically hide thus keeping show desktop enabled and the config dialog disappears immediately after it was shown.

I guess this is because hide on window deactivate in Dialog checks for whether I tapped a containment, which I did, and then keeps the dialog open.

Diffs

desktoppackage/contents/explorer/AppletDelegate.qml (c315b4c)
desktoppackage/contents/explorer/WidgetExplorer.qml (90e84d3)

--===============3585834072453930681==-- --===============2965808848359963116== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============2965808848359963116==--