'Re: Review Request 126930: sddm theme: Add keyboard layout button'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 126930: sddm theme: Add keyboard layout button
From:       David Rosca <nowrep () gmail ! com>
Date:       2016-01-30 22:59:35
Message-ID: 20160130225935.17778.31922 () mimi ! kde ! org
[Download RAW message or body]

--===============3769061253886585620==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126930/
-----------------------------------------------------------

(Updated Jan. 30, 2016, 10:59 p.m.)

Review request for Plasma.

Changes
-------

`visible: keyboard.layouts.length > 1` as in lock screen

Repository: plasma-workspace

Description
-------

Show keyboard layout button in sddm theme, same as in lock screen.

Diffs (updated)
-----

  lookandfeel/contents/loginmanager/Main.qml 1bbefec 
  lookandfeel/contents/loginmanager/dummydata/keyboard.qml PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/126930/diff/

Testing
-------

Looks & works exactly the same as in lock screen.

Btw, there is a comment saying that password input must be first child to get focus \
(automatically when login screen is shown?), but it is not true. It works fine (in \
all cases = qmlscene, sddm-greeter --test-mode and in actual sddm session) even with \
password input being second child. So, remove the comment?

Thanks,

David Rosca

--===============3769061253886585620==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126930/">https://git.reviewboard.kde.org/r/126930/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By David Rosca.</div>

<p style="color: grey;"><i>Updated Jan. 30, 2016, 10:59 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">`visible: keyboard.layouts.length &gt; 1` as in lock screen</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Show keyboard layout button in sddm theme, same as in \
lock screen.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Looks &amp; works exactly the same as in lock \
screen.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Btw, there is a comment saying that password input \
must be first child to get focus (automatically when login screen is shown?), but it \
is not true. It works fine (in all cases = qmlscene, sddm-greeter --test-mode and in \
actual sddm session) even with password input being second child. So, remove the \
comment?</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>lookandfeel/contents/loginmanager/Main.qml <span style="color: \
grey">(1bbefec)</span></li>

 <li>lookandfeel/contents/loginmanager/dummydata/keyboard.qml <span style="color: \
grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126930/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============3769061253886585620==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 