From kde-panel-devel Sat Jan 30 22:59:35 2016 From: David Rosca Date: Sat, 30 Jan 2016 22:59:35 +0000 To: kde-panel-devel Subject: Re: Review Request 126930: sddm theme: Add keyboard layout button Message-Id: <20160130225935.17778.31922 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=145419479016907 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1875002640773761461==" --===============1875002640773761461== Content-Type: multipart/alternative; boundary="===============3769061253886585620==" --===============3769061253886585620== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126930/ ----------------------------------------------------------- (Updated Jan. 30, 2016, 10:59 p.m.) Review request for Plasma. Changes ------- `visible: keyboard.layouts.length > 1` as in lock screen Repository: plasma-workspace Description ------- Show keyboard layout button in sddm theme, same as in lock screen. Diffs (updated) ----- lookandfeel/contents/loginmanager/Main.qml 1bbefec lookandfeel/contents/loginmanager/dummydata/keyboard.qml PRE-CREATION Diff: https://git.reviewboard.kde.org/r/126930/diff/ Testing ------- Looks & works exactly the same as in lock screen. Btw, there is a comment saying that password input must be first child to get focus (automatically when login screen is shown?), but it is not true. It works fine (in all cases = qmlscene, sddm-greeter --test-mode and in actual sddm session) even with password input being second child. So, remove the comment? Thanks, David Rosca --===============3769061253886585620== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126930/

Review request for Plasma.

By David Rosca.

Updated Jan. 30, 2016, 10:59 p.m.

Changes

`visible: keyboard.layouts.length > 1` as in lock screen

Repository: plasma-workspace

Description

Show keyboard layout button in sddm theme, same as in lock screen.

Testing

Looks & works exactly the same as in lock screen.

Btw, there is a comment saying that password input must be first child to get focus (automatically when login screen is shown?), but it is not true. It works fine (in all cases = qmlscene, sddm-greeter --test-mode and in actual sddm session) even with password input being second child. So, remove the comment?

Diffs (updated)

lookandfeel/contents/loginmanager/Main.qml (1bbefec)
lookandfeel/contents/loginmanager/dummydata/keyboard.qml (PRE-CREATION)

View Diff

--===============3769061253886585620==-- --===============1875002640773761461== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============1875002640773761461==--