'Re: Review Request 126551: [Service Runner] WIP: Add support for Jump List Actions'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 126551: [Service Runner] WIP: Add support for Jump List Actions
From:       Kai Uwe Broulik <kde () privat ! broulik ! de>
Date:       2016-01-30 19:32:43
Message-ID: 20160130193243.7900.62295 () mimi ! kde ! org
[Download RAW message or body]

--===============5318795678484726497==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126551/
-----------------------------------------------------------

(Updated Jan. 30, 2016, 7:32 nachm.)

Status
------

This change has been discarded.

Review request for Plasma and Vishesh Handa.

Repository: plasma-workspace

Description
-------

This adds support for Jump List Actions to the Services runner

I wanted to make the Jump Lists themselves searchable, so you can also enter "Big \
Picture" and it finds the associated service with it but I couldn't figure out how I \
can search Desktop Actions through KServiceTypeTrader. Commented in the code is a \
crude approach.

Also, I can't figure out how I could stick those entries toegether, it should always \
be "Main App - action - action - action - Some other App", sometimes it shuffles them \
again although I tried hard to have them stick together.

I need a better way to distinguish app results and jump list results, I used the \
match type but that obviously doesn't work now. I don't want QString matching the \
data, though.

Finally, I want those results not to show up in Kickoff, is this possible?

I removed the context.isValid() check in the loops as it's done once before all of \
them.

Diffs
-----

  runners/services/servicerunner.h a4171bc 
  runners/services/servicerunner.cpp 27df5ab 

Diff: https://git.reviewboard.kde.org/r/126551/diff/

Testing
-------

Searched for "steam", got Steam as well as its associated actions
Searched for "spectacle", got its associated capture modes

File Attachments
----------------

Steam in KRunner
  https://git.reviewboard.kde.org/media/uploaded/files/2015/12/28/9f3046f1-6acb-460d-a515-6abab6522dfe__krunnerjumplists.png

Thanks,

Kai Uwe Broulik

--===============5318795678484726497==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126551/">https://git.reviewboard.kde.org/r/126551/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma and Vishesh Handa.</div>
<div>By Kai Uwe Broulik.</div>

<p style="color: grey;"><i>Updated Jan. 30, 2016, 7:32 nachm.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This adds support for Jump List Actions to the \
Services runner</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">I wanted to make the Jump Lists \
themselves searchable, so you can also enter "Big Picture" and it finds the \
associated service with it but I couldn't figure out how I can search Desktop Actions \
through KServiceTypeTrader. Commented in the code is a crude approach.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Also, I can't figure out how I could stick those entries toegether, it \
should always be "Main App - action - action - action - Some other App", sometimes it \
shuffles them again although I tried hard to have them stick together.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">I need a better way to distinguish app results and jump list results, I \
used the match type but that obviously doesn't work now. I don't want QString \
matching the data, though.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Finally, I want those results not to \
show up in Kickoff, is this possible?</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">I removed the \
context.isValid() check in the loops as it's done once before all of them.</p></pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Searched for "steam", got Steam as well as its \
associated actions Searched for "spectacle", got its associated capture \
modes</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>runners/services/servicerunner.h <span style="color: grey">(a4171bc)</span></li>

 <li>runners/services/servicerunner.cpp <span style="color: \
grey">(27df5ab)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126551/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/12/28/9f3046f1-6acb-460d-a515-6abab6522dfe__krunnerjumplists.png">Steam \
in KRunner</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============5318795678484726497==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 