--===============0164009026922909198== Content-Type: multipart/alternative; boundary="===============5318795678484726497==" --===============5318795678484726497== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126551/ ----------------------------------------------------------- (Updated Jan. 30, 2016, 7:32 nachm.) Status ------ This change has been discarded. Review request for Plasma and Vishesh Handa. Repository: plasma-workspace Description ------- This adds support for Jump List Actions to the Services runner I wanted to make the Jump Lists themselves searchable, so you can also enter "Big Picture" and it finds the associated service with it but I couldn't figure out how I can search Desktop Actions through KServiceTypeTrader. Commented in the code is a crude approach. Also, I can't figure out how I could stick those entries toegether, it should always be "Main App - action - action - action - Some other App", sometimes it shuffles them again although I tried hard to have them stick together. I need a better way to distinguish app results and jump list results, I used the match type but that obviously doesn't work now. I don't want QString matching the data, though. Finally, I want those results not to show up in Kickoff, is this possible? I removed the context.isValid() check in the loops as it's done once before all of them. Diffs ----- runners/services/servicerunner.h a4171bc runners/services/servicerunner.cpp 27df5ab Diff: https://git.reviewboard.kde.org/r/126551/diff/ Testing ------- Searched for "steam", got Steam as well as its associated actions Searched for "spectacle", got its associated capture modes File Attachments ---------------- Steam in KRunner https://git.reviewboard.kde.org/media/uploaded/files/2015/12/28/9f3046f1-6acb-460d-a515-6abab6522dfe__krunnerjumplists.png Thanks, Kai Uwe Broulik --===============5318795678484726497== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126551/

This change has been discarded.

Review request for Plasma and Vishesh Handa.

By Kai Uwe Broulik.

Updated Jan. 30, 2016, 7:32 nachm.

Repository: plasma-workspace

Description

This adds support for Jump List Actions to the Services runner

I wanted to make the Jump Lists themselves searchable, so you can also enter "Big Picture" and it finds the associated service with it but I couldn't figure out how I can search Desktop Actions through KServiceTypeTrader. Commented in the code is a crude approach.

Also, I can't figure out how I could stick those entries toegether, it should always be "Main App - action - action - action - Some other App", sometimes it shuffles them again although I tried hard to have them stick together.

I need a better way to distinguish app results and jump list results, I used the match type but that obviously doesn't work now. I don't want QString matching the data, though.

Finally, I want those results not to show up in Kickoff, is this possible?

I removed the context.isValid() check in the loops as it's done once before all of them.

Testing

Searched for "steam", got Steam as well as its associated actions Searched for "spectacle", got its associated capture modes

Diffs

runners/services/servicerunner.h (a4171bc)
runners/services/servicerunner.cpp (27df5ab)

File Attachments

Steam in KRunner

--===============5318795678484726497==-- --===============0164009026922909198== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============0164009026922909198==--