'Re: Review Request 126893: [kioslave/remote] fix knetattach .desktop filename'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 126893: [kioslave/remote] fix knetattach .desktop filename
From:       Takahiro Hashimoto <kenya888 () gmail ! com>
Date:       2016-01-29 8:11:23
Message-ID: 20160129081123.17778.56777 () mimi ! kde ! org
[Download RAW message or body]

--===============6951631021795345824==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126893/
-----------------------------------------------------------

(Updated Jan. 29, 2016, 5:11 p.m.)

Review request for Plasma.

Changes
-------

file the bug on the bugzilla.

Bugs: 358723
    https://bugs.kde.org/show_bug.cgi?id=358723

Repository: plasma-workspace

Description
-------

The knetattach .desktop file has been renamed to 'org.kde.knetattach.desktop'.
The wizard service name should be changed to the same string.

This patch simply fixes service name of knetatach.

Diffs
-----

  kioslave/remote/remoteimpl.cpp ad04a7b 

Diff: https://git.reviewboard.kde.org/r/126893/diff/

Testing
-------

Confirmed the "Add Network Folder" icon rework in dolphin.
kioslave/remote/tests/testremote has been passed.

We may have some issues about knetattach. At present I cannot create sftp network folder. I \
have confirmed that the ftp network folder works correctly.

Thanks,

Takahiro Hashimoto

--===============6951631021795345824==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126893/">https://git.reviewboard.kde.org/r/126893/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px \
#888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Takahiro Hashimoto.</div>

<p style="color: grey;"><i>Updated Jan. 29, 2016, 5:11 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">file the bug on the \
bugzilla.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://bugs.kde.org/show_bug.cgi?id=358723">358723</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The knetattach \
.desktop file has been renamed to &#39;org.kde.knetattach.desktop&#39;. The wizard service name \
should be changed to the same string.

This patch simply fixes service name of knetatach.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Confirmed the \
"Add Network Folder" icon rework in dolphin. kioslave/remote/tests/testremote has been \
passed.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">We may have some issues about knetattach. At present I cannot \
create sftp network folder. I have confirmed that the ftp network folder works \
correctly.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kioslave/remote/remoteimpl.cpp <span style="color: grey">(ad04a7b)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126893/diff/" style="margin-left: 3em;">View \
Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============6951631021795345824==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 