From kde-panel-devel Fri Jan 29 08:11:23 2016 From: Takahiro Hashimoto Date: Fri, 29 Jan 2016 08:11:23 +0000 To: kde-panel-devel Subject: Re: Review Request 126893: [kioslave/remote] fix knetattach .desktop filename Message-Id: <20160129081123.17778.56777 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=145405510418082 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1980384307450713025==" --===============1980384307450713025== Content-Type: multipart/alternative; boundary="===============6951631021795345824==" --===============6951631021795345824== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126893/ ----------------------------------------------------------- (Updated Jan. 29, 2016, 5:11 p.m.) Review request for Plasma. Changes ------- file the bug on the bugzilla. Bugs: 358723 https://bugs.kde.org/show_bug.cgi?id=358723 Repository: plasma-workspace Description ------- The knetattach .desktop file has been renamed to 'org.kde.knetattach.desktop'. The wizard service name should be changed to the same string. This patch simply fixes service name of knetatach. Diffs ----- kioslave/remote/remoteimpl.cpp ad04a7b Diff: https://git.reviewboard.kde.org/r/126893/diff/ Testing ------- Confirmed the "Add Network Folder" icon rework in dolphin. kioslave/remote/tests/testremote has been passed. We may have some issues about knetattach. At present I cannot create sftp network folder. I have confirmed that the ftp network folder works correctly. Thanks, Takahiro Hashimoto --===============6951631021795345824== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126893/

Review request for Plasma.

By Takahiro Hashimoto.

Updated Jan. 29, 2016, 5:11 p.m.

Changes

file the bug on the bugzilla.

Bugs: 358723

Repository: plasma-workspace

Description

The knetattach .desktop file has been renamed to 'org.kde.knetattach.desktop'.
The wizard service name should be changed to the same string.

This patch simply fixes service name of knetatach.

Testing

Confirmed the "Add Network Folder" icon rework in dolphin. kioslave/remote/tests/testremote has been passed.

We may have some issues about knetattach. At present I cannot create sftp network folder. I have confirmed that the ftp network folder works correctly.

Diffs

kioslave/remote/remoteimpl.cpp (ad04a7b)

View Diff

--===============6951631021795345824==-- --===============1980384307450713025== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============1980384307450713025==--