'Re: Review Request 126878: [KRunner] Show single runner name'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 126878: [KRunner] Show single runner name
From:       Vishesh Handa <me () vhanda ! in>
Date:       2016-01-28 21:11:25
Message-ID: 20160128211125.17778.8858 () mimi ! kde ! org
[Download RAW message or body]

--===============5846996386004730558==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

> On Jan. 27, 2016, 9 a.m., Vishesh Handa wrote:
> > * A single runner can have multiple categories in its response.
> > * I see nothing from a technical point of view in the patch. I find it slightly ugly, but if the \
> > usability guys (and Plasma) are fine with it, ship it!

*nothing wrong

- Vishesh

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126878/#review91645
-----------------------------------------------------------

On Jan. 24, 2016, 9:49 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126878/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2016, 9:49 p.m.)
> 
> 
> Review request for Plasma, KDE Usability and Vishesh Handa.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> When in single runner mode (ie. only use a specific runner rather than querying them all) show the name \
> of the current runner. 
> This restores Plasma 4 behavior and is also somewhat in preparation for the global menu runner where it \
> should be clear that I would currently be searching through the current application's menu. 
> 
> Diffs
> -----
> 
> lookandfeel/contents/runcommand/RunCommand.qml 43f7c55 
> 
> Diff: https://git.reviewboard.kde.org/r/126878/diff/
> 
> 
> Testing
> -------
> 
> Name properly shows, layout works both ways without the window getting wider.
> 
> I just noticed I could probably hide the category label next to the search result, too, as it's now \
> redundant but I don't know whether a runner can still set a different value for that or if that's \
> always just the runner name? 
> 
> File Attachments
> ----------------
> 
> Runner name label
> https://git.reviewboard.kde.org/media/uploaded/files/2016/01/24/d398ee71-78e5-458f-ad48-cf4fe828156f__runnername.png
>  
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
> 

--===============5846996386004730558==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126878/">https://git.reviewboard.kde.org/r/126878/</a>
     </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
 <p style="margin-top: 0;">On January 27th, 2016, 9 a.m. UTC, <b>Vishesh Handa</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 \
1em;line-height: inherit;white-space: normal;"> <li style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">A single runner can have multiple categories in its \
response.</li> <li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">I see nothing from a technical point of view in the patch. I find it slightly ugly, but if the \
usability guys (and Plasma) are fine with it, ship it!</li> </ul></pre>
 </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">*nothing wrong</p></pre> <br />

<p>- Vishesh</p>

<br />
<p>On January 24th, 2016, 9:49 p.m. UTC, Kai Uwe Broulik wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma, KDE Usability and Vishesh Handa.</div>
<div>By Kai Uwe Broulik.</div>

<p style="color: grey;"><i>Updated Jan. 24, 2016, 9:49 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">When in single runner mode (ie. only use a \
specific runner rather than querying them all) show the name of the current runner.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This \
restores Plasma 4 behavior and is also somewhat in preparation for the global menu runner where it should \
be clear that I would currently be searching through the current application's menu.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Name properly shows, layout works both ways \
without the window getting wider.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I just noticed I could probably hide the category label next to the search \
result, too, as it's now redundant but I don't know whether a runner can still set a different value for \
that or if that's always just the runner name?</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>lookandfeel/contents/runcommand/RunCommand.qml <span style="color: grey">(43f7c55)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126878/diff/" style="margin-left: 3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/01/24/d398ee71-78e5-458f-ad48-cf4fe828156f__runnername.png">Runner \
name label</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============5846996386004730558==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 