--===============2594712646799032965== Content-Type: multipart/alternative; boundary="===============5846996386004730558==" --===============5846996386004730558== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Jan. 27, 2016, 9 a.m., Vishesh Handa wrote: > > * A single runner can have multiple categories in its response. > > * I see nothing from a technical point of view in the patch. I find it slightly ugly, but if the usability guys (and Plasma) are fine with it, ship it! *nothing wrong - Vishesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126878/#review91645 ----------------------------------------------------------- On Jan. 24, 2016, 9:49 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126878/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2016, 9:49 p.m.) > > > Review request for Plasma, KDE Usability and Vishesh Handa. > > > Repository: plasma-workspace > > > Description > ------- > > When in single runner mode (ie. only use a specific runner rather than querying them all) show the name of the current runner. > > This restores Plasma 4 behavior and is also somewhat in preparation for the global menu runner where it should be clear that I would currently be searching through the current application's menu. > > > Diffs > ----- > > lookandfeel/contents/runcommand/RunCommand.qml 43f7c55 > > Diff: https://git.reviewboard.kde.org/r/126878/diff/ > > > Testing > ------- > > Name properly shows, layout works both ways without the window getting wider. > > I just noticed I could probably hide the category label next to the search result, too, as it's now redundant but I don't know whether a runner can still set a different value for that or if that's always just the runner name? > > > File Attachments > ---------------- > > Runner name label > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/24/d398ee71-78e5-458f-ad48-cf4fe828156f__runnername.png > > > Thanks, > > Kai Uwe Broulik > > --===============5846996386004730558== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126878/

On January 27th, 2016, 9 a.m. UTC, Vishesh Handa wrote:

    

  • A single runner can have multiple categories in its response.
    • 

  • I see nothing from a technical point of view in the patch. I find it slightly ugly, but if the usability guys (and Plasma) are fine with it, ship it!
    • 

*nothing wrong

- Vishesh


On January 24th, 2016, 9:49 p.m. UTC, Kai Uwe Broulik wrote:

Review request for Plasma, KDE Usability and Vishesh Handa.
By Kai Uwe Broulik.

Updated Jan. 24, 2016, 9:49 p.m.

Repository: plasma-workspace

Description 

When in single runner mode (ie. only use a specific runner rather than querying them all) show the name of the current runner.


This restores Plasma 4 behavior and is also somewhat in preparation for the global menu runner where it should be clear that I would currently be searching through the current application's menu.

Testing 

Name properly shows, layout works both ways without the window getting wider.


I just noticed I could probably hide the category label next to the search result, too, as it's now redundant but I don't know whether a runner can still set a different value for that or if that's always just the runner name?

Diffs

  • lookandfeel/contents/runcommand/RunCommand.qml (43f7c55)

View Diff

File Attachments

  • Runner name label
    		•
    --===============5846996386004730558==-- --===============2594712646799032965== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============2594712646799032965==--