'Re: Review Request 126517: [ShellManager] Make use of StatusNotifier DrKonqi'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 126517: [ShellManager] Make use of StatusNotifier DrKonqi
From:       "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date:       2015-12-29 23:10:11
Message-ID: 20151229231011.18086.15744 () mimi ! kde ! org
[Download RAW message or body]

--===============0136653340000830817==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126517/
-----------------------------------------------------------

(Updated Dez. 29, 2015, 11:10 nachm.)

Status
------

This change has been discarded.

Review request for Plasma.

Repository: plasma-workspace

Description
-------

This enables the StatusNotifier option introduced in Review 126516, see Review 126515 \
for more information.

When Plasma reached the recursion counter it disables the passive option since there \
will most likely be no System Tray to show this error and then something's really \
wrong in the first place.

Diffs
-----

  shell/shellmanager.cpp 0a6ac5e 

Diff: https://git.reviewboard.kde.org/r/126517/diff/

Testing
-------

Crashed plasma two times, it restarted and I got two SNIs, crashed it another time, \
got black screen with DrKonqi dialog.

Thanks,

Kai Uwe Broulik

--===============0136653340000830817==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126517/">https://git.reviewboard.kde.org/r/126517/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Kai Uwe Broulik.</div>

<p style="color: grey;"><i>Updated Dez. 29, 2015, 11:10 nachm.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This enables the StatusNotifier option introduced in \
Review 126516, see Review 126515 for more information.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">When \
Plasma reached the recursion counter it disables the passive option since there will \
most likely be no System Tray to show this error and then something's really wrong in \
the first place.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Crashed plasma two times, it restarted and I got two \
SNIs, crashed it another time, got black screen with DrKonqi dialog.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>shell/shellmanager.cpp <span style="color: grey">(0a6ac5e)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126517/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============0136653340000830817==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 