From kde-panel-devel Tue Dec 29 23:10:11 2015 From: "Kai Uwe Broulik" Date: Tue, 29 Dec 2015 23:10:11 +0000 To: kde-panel-devel Subject: Re: Review Request 126517: [ShellManager] Make use of StatusNotifier DrKonqi Message-Id: <20151229231011.18086.15744 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=145143062413051 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============5780660744501431880==" --===============5780660744501431880== Content-Type: multipart/alternative; boundary="===============0136653340000830817==" --===============0136653340000830817== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126517/ ----------------------------------------------------------- (Updated Dez. 29, 2015, 11:10 nachm.) Status ------ This change has been discarded. Review request for Plasma. Repository: plasma-workspace Description ------- This enables the StatusNotifier option introduced in Review 126516, see Review 126515 for more information. When Plasma reached the recursion counter it disables the passive option since there will most likely be no System Tray to show this error and then something's really wrong in the first place. Diffs ----- shell/shellmanager.cpp 0a6ac5e Diff: https://git.reviewboard.kde.org/r/126517/diff/ Testing ------- Crashed plasma two times, it restarted and I got two SNIs, crashed it another time, got black screen with DrKonqi dialog. Thanks, Kai Uwe Broulik --===============0136653340000830817== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126517/

This change has been discarded.

Review request for Plasma.
By Kai Uwe Broulik.

Updated Dez. 29, 2015, 11:10 nachm.

Repository: plasma-workspace

Description 

This enables the StatusNotifier option introduced in Review 126516, see Review 126515 for more information.


When Plasma reached the recursion counter it disables the passive option since there will most likely be no System Tray to show this error and then something's really wrong in the first place.

Testing 

Crashed plasma two times, it restarted and I got two SNIs, crashed it another time, got black screen with DrKonqi dialog.

Diffs

  • shell/shellmanager.cpp (0a6ac5e)

View Diff
--===============0136653340000830817==-- --===============5780660744501431880== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============5780660744501431880==--