'Re: Review Request 126567: [ToolButtonStyle] Always indicate activeFocus'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 126567: [ToolButtonStyle] Always indicate activeFocus
From:       "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date:       2015-12-29 22:43:23
Message-ID: 20151229224323.18086.58592 () mimi ! kde ! org
[Download RAW message or body]

--===============5504873527136309854==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126567/
-----------------------------------------------------------

(Updated Dec. 29, 2015, 10:43 p.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma.

Changes
-------

Submitted with commit 81a03ef29129f32faa41f332a4dede229b25a1a8 by Kai Uwe Broulik to \
branch master.

Repository: plasma-framework

Description
-------

Even when flat we should indicate that a ToolButton has active focus. This makes \
keyboard navigation much less awkward to use.

Unfortunately activeFocus stays there even if I click another button (and we probably \
don't want activeFocusOnPress by default or else we always end up with one strange \
highlighted ToolButton, ooohh QML and keyboards)

Diffs
-----

  src/declarativeimports/plasmastyle/ToolButtonStyle.qml c9502e7 

Diff: https://git.reviewboard.kde.org/r/126567/diff/

Testing
-------

I can tab through plasma-nm and mediacontroller and actually see where I'm going

File Attachments
----------------

Media Controller focus
  https://git.reviewboard.kde.org/media/uploaded/files/2015/12/29/48804e09-f3c3-42b0-8e4b-a12ff9b9c2ed__Screenshot_20151229_225847.png

Thanks,

Kai Uwe Broulik

--===============5504873527136309854==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126567/">https://git.reviewboard.kde.org/r/126567/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Kai Uwe Broulik.</div>

<p style="color: grey;"><i>Updated Dec. 29, 2015, 10:43 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 81a03ef29129f32faa41f332a4dede229b25a1a8 by Kai \
Uwe Broulik to branch master.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Even when flat we should indicate that a ToolButton \
has active focus. This makes keyboard navigation much less awkward to use.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Unfortunately activeFocus stays there even if I click another button (and \
we probably don't want activeFocusOnPress by default or else we always end up with \
one strange highlighted ToolButton, ooohh QML and keyboards)</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I can tab through plasma-nm and mediacontroller and \
actually see where I'm going</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/declarativeimports/plasmastyle/ToolButtonStyle.qml <span style="color: \
grey">(c9502e7)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126567/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/12/29/48804e09-f3c3-42b0-8e4b-a12ff9b9c2ed__Screenshot_20151229_225847.png">Media \
Controller focus</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============5504873527136309854==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 