--===============8603016733333893643== Content-Type: multipart/alternative; boundary="===============5504873527136309854==" --===============5504873527136309854== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126567/ ----------------------------------------------------------- (Updated Dec. 29, 2015, 10:43 p.m.) Status ------ This change has been marked as submitted. Review request for Plasma. Changes ------- Submitted with commit 81a03ef29129f32faa41f332a4dede229b25a1a8 by Kai Uwe Broulik to branch master. Repository: plasma-framework Description ------- Even when flat we should indicate that a ToolButton has active focus. This makes keyboard navigation much less awkward to use. Unfortunately activeFocus stays there even if I click another button (and we probably don't want activeFocusOnPress by default or else we always end up with one strange highlighted ToolButton, ooohh QML and keyboards) Diffs ----- src/declarativeimports/plasmastyle/ToolButtonStyle.qml c9502e7 Diff: https://git.reviewboard.kde.org/r/126567/diff/ Testing ------- I can tab through plasma-nm and mediacontroller and actually see where I'm going File Attachments ---------------- Media Controller focus https://git.reviewboard.kde.org/media/uploaded/files/2015/12/29/48804e09-f3c3-42b0-8e4b-a12ff9b9c2ed__Screenshot_20151229_225847.png Thanks, Kai Uwe Broulik --===============5504873527136309854== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126567/

This change has been marked as submitted.

Review request for Plasma.

By Kai Uwe Broulik.

Updated Dec. 29, 2015, 10:43 p.m.

Changes

Submitted with commit 81a03ef29129f32faa41f332a4dede229b25a1a8 by Kai Uwe Broulik to branch master.

Repository: plasma-framework

Description

Even when flat we should indicate that a ToolButton has active focus. This makes keyboard navigation much less awkward to use.

Unfortunately activeFocus stays there even if I click another button (and we probably don't want activeFocusOnPress by default or else we always end up with one strange highlighted ToolButton, ooohh QML and keyboards)

Testing

I can tab through plasma-nm and mediacontroller and actually see where I'm going

Diffs

src/declarativeimports/plasmastyle/ToolButtonStyle.qml (c9502e7)

View Diff

File Attachments

Media Controller focus

--===============5504873527136309854==-- --===============8603016733333893643== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============8603016733333893643==--