'Re: Review Request 126149: [Icon widget] Bring back properties dialog'

[prev in list] [next in list] [prev in thread] [next in thread] 

List: kde-panel-devel
Subject: Re: Review Request 126149: [Icon widget] Bring back properties dialog
From: "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date: 2015-12-29 18:07:04
Message-ID: 20151229180704.18086.77093 () mimi ! kde ! org
[Download RAW message or body]

--===============4351593679079797975==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126149/#review90298
-----------------------------------------------------------

I completely screwed up my Kate desktop files :( Would it help if I set \
NoDisplay or Hidden on the desktop file copy so it's there for the icon \
widget but not shown in the Open With dialogs and so on? Or, if I copied \
the desktop file elsewhere (eg. not into the local share applications)?

Also, I should probably delete the desktop file again if the widget is \
removed :)

- Kai Uwe Broulik

On Dez. 21, 2015, 11:31 nachm., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126149/
> -----------------------------------------------------------
> 
> (Updated Dez. 21, 2015, 11:31 nachm.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 349177
> https://bugs.kde.org/show_bug.cgi?id=349177
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This brings back the KPropertiesDialog to modify an icon's appearance. \
> This has been requested at multiple occasions. This has been adapted from \
> the Plasma 4 icon code. 
> 
> Diffs
> -----
> 
> applets/icon/package/contents/ui/main.qml 9286b94 
> applets/icon/plugin/icon_p.h dd7963c 
> applets/icon/plugin/icon_p.cpp e086870 
> 
> Diff: https://git.reviewboard.kde.org/r/126149/diff/
> 
> 
> Testing
> -------
> 
> Dropped a file from my home onto the desktop -> dialog from the actual \
> file, allowing to rename it. The applet reflected the changes. 
> Dropped an application from kickoff to the desktop -> dialog from a copy \
> of the desktop file, allowing to change its icon and description. The \
> applet reflected the changes. 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
> 

--===============4351593679079797975==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: \
1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126149/">https://git.reviewboard.kde.org/r/126149/</a>
  </td>
    </tr>
   </table>
   <br />

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I completely screwed up my \
Kate desktop files :( Would it help if I set NoDisplay or Hidden on the \
desktop file copy so it's there for the icon widget but not shown in the \
Open With dialogs and so on? Or, if I copied the desktop file elsewhere \
(eg. not into the local share applications)? Also, I should probably delete the desktop file again if the \
widget is removed :)</pre>

<p>- Kai Uwe Broulik</p>

<br />
<p>On Dezember 21st, 2015, 11:31 nachm. UTC, Kai Uwe Broulik wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" \
style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: \
6px; -webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks and Plasma.</div>
<div>By Kai Uwe Broulik.</div>

<p style="color: grey;"><i>Updated Dez. 21, 2015, 11:31 nachm.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://bugs.kde.org/show_bug.cgi?id=349177">349177</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
</h1>  <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">This brings back the \
KPropertiesDialog to modify an icon's appearance. This has been requested \
at multiple occasions. This has been adapted from the Plasma 4 icon \
code.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Dropped a file from my home \
onto the desktop -&gt; dialog from the actual file, allowing to rename it. \
The applet reflected the changes.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Dropped an \
application from kickoff to the desktop -&gt; dialog from a copy of the \
desktop file, allowing to change its icon and description. The applet \
reflected the changes.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/icon/package/contents/ui/main.qml <span style="color: \
grey">(9286b94)</span></li>

 <li>applets/icon/plugin/icon_p.h <span style="color: \
grey">(dd7963c)</span></li>

 <li>applets/icon/plugin/icon_p.cpp <span style="color: \
grey">(e086870)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126149/diff/" \
style="margin-left: 3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============4351593679079797975==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 