--===============1516661481844246517== Content-Type: multipart/alternative; boundary="===============4351593679079797975==" --===============4351593679079797975== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126149/#review90298 ----------------------------------------------------------- I completely screwed up my Kate desktop files :( Would it help if I set NoDisplay or Hidden on the desktop file copy so it's there for the icon widget but not shown in the Open With dialogs and so on? Or, if I copied the desktop file elsewhere (eg. not into the local share applications)? Also, I should probably delete the desktop file again if the widget is removed :) - Kai Uwe Broulik On Dez. 21, 2015, 11:31 nachm., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126149/ > ----------------------------------------------------------- > > (Updated Dez. 21, 2015, 11:31 nachm.) > > > Review request for KDE Frameworks and Plasma. > > > Bugs: 349177 > https://bugs.kde.org/show_bug.cgi?id=349177 > > > Repository: plasma-workspace > > > Description > ------- > > This brings back the KPropertiesDialog to modify an icon's appearance. This has been requested at multiple occasions. This has been adapted from the Plasma 4 icon code. > > > Diffs > ----- > > applets/icon/package/contents/ui/main.qml 9286b94 > applets/icon/plugin/icon_p.h dd7963c > applets/icon/plugin/icon_p.cpp e086870 > > Diff: https://git.reviewboard.kde.org/r/126149/diff/ > > > Testing > ------- > > Dropped a file from my home onto the desktop -> dialog from the actual file, allowing to rename it. The applet reflected the changes. > > Dropped an application from kickoff to the desktop -> dialog from a copy of the desktop file, allowing to change its icon and description. The applet reflected the changes. > > > Thanks, > > Kai Uwe Broulik > > --===============4351593679079797975== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126149/

I completely screwed up my Kate desktop files :( Would it help if I set NoDisplay or Hidden on the desktop file copy so it's there for the icon widget but not shown in the Open With dialogs and so on? Or, if I copied the desktop file elsewhere (eg. not into the local share applications)?

Also, I should probably delete the desktop file again if the widget is removed :)

- Kai Uwe Broulik

On Dezember 21st, 2015, 11:31 nachm. UTC, Kai Uwe Broulik wrote:

Review request for KDE Frameworks and Plasma.

By Kai Uwe Broulik.

Updated Dez. 21, 2015, 11:31 nachm.

Bugs: 349177

Repository: plasma-workspace

Description

This brings back the KPropertiesDialog to modify an icon's appearance. This has been requested at multiple occasions. This has been adapted from the Plasma 4 icon code.

Testing

Dropped a file from my home onto the desktop -> dialog from the actual file, allowing to rename it. The applet reflected the changes.

Dropped an application from kickoff to the desktop -> dialog from a copy of the desktop file, allowing to change its icon and description. The applet reflected the changes.

Diffs

applets/icon/package/contents/ui/main.qml (9286b94)
applets/icon/plugin/icon_p.h (dd7963c)
applets/icon/plugin/icon_p.cpp (e086870)

--===============4351593679079797975==-- --===============1516661481844246517== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============1516661481844246517==--