[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 124962: Fix CMAKE_INSTALL_LIBDIR not respecting installation prefix
From:       Martin Klapetek <martin.klapetek () gmail ! com>
Date:       2015-12-10 20:45:54
Message-ID: CAPLgePruL+5Quz=UEorUjg+ByJ3a6oZ4dXvVUQ+qju-NHE=9fA () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Hey,

On Thu, Dec 10, 2015 at 2:54 PM, Maximiliano Curia <maxy@gnuservers.com.ar>
wrote:

> Hi,
>
> Sorry that I haven't seen this review before plasma 5.5 was released
> (containing this change), but pam modules are traditionally installed in
> /lib,
> that is, with an empty prefix. In the same CMakeLists.txt you can read the
> intention to honor this:
> set_target_properties (${library_name} PROPERTIES PREFIX "")
>
> Sadly, this alone is not sufficient, thus the / in the install rule.
>
> This change forces me to introduce the attached patch in the Debian
> package,
> as pam modules should be available even if /usr is not mounted.
>

Thanks for getting in touch!

However if I'm not mistaken, that set_target_properties call does not
do what you imply it does. Setting empty PREFIX means that it will
not prepend "lib" to the filename, eg. "libpam_kwallet.so", but will instead
name it "pam_kwallet.so".

It has nothing to do with install paths.

If you want to have it installed in /lib, just set CMAKE_INSTALL_PREFIX
to "/", then it should install into /lib correctly.

Cheers
-- 
Martin Klapetek | KDE Developer

[Attachment #5 (text/html)]

<div dir="ltr">Hey,<br><div><div class="gmail_extra"><br><div class="gmail_quote">On \
Thu, Dec 10, 2015 at 2:54 PM, Maximiliano Curia <span dir="ltr">&lt;<a \
href="mailto:maxy@gnuservers.com.ar" \
target="_blank">maxy@gnuservers.com.ar</a>&gt;</span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex">Hi,<br> <br>
Sorry that I haven&#39;t seen this review before plasma 5.5 was released<br>
(containing this change), but pam modules are traditionally installed in /lib,<br>
that is, with an empty prefix. In the same CMakeLists.txt you can read the<br>
intention to honor this:<br>
set_target_properties (${library_name} PROPERTIES PREFIX &quot;&quot;)<br>
<br>
Sadly, this alone is not sufficient, thus the / in the install rule.<br>
<br>
This change forces me to introduce the attached patch in the Debian package,<br>
as pam modules should be available even if /usr is not \
mounted.<br></blockquote><div><br></div><div>Thanks for getting in \
touch!<br><br></div><div>However if I&#39;m not mistaken, that set_target_properties \
call does not<br></div><div>do what you imply it does. Setting empty PREFIX means \
that it will<br></div><div>not prepend &quot;lib&quot; to the filename, eg. \
&quot;libpam_kwallet.so&quot;, but will instead<br></div><div>name it \
&quot;pam_kwallet.so&quot;.<br><br></div><div>It has nothing to do with install \
paths.<br><br></div><div>If you want to have it installed in /lib, just set  \
CMAKE_INSTALL_PREFIX<br>to &quot;/&quot;, then it should install into /lib \
correctly.<br></div></div><br></div><div class="gmail_extra">Cheers<br></div><div \
class="gmail_extra">-- <br><div class="gmail_signature"><div><span \
style="color:rgb(102,102,102)">Martin Klapetek | KDE  Developer</span></div></div> \
</div></div></div>


[Attachment #6 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]