[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 124962: Fix CMAKE_INSTALL_LIBDIR not respecting installation prefix
From:       Maximiliano Curia <maxy () gnuservers ! com ! ar>
Date:       2015-12-10 19:54:57
Message-ID: 5669D891.6080205 () gnuservers ! com ! ar
[Download RAW message or body]

[Attachment #2 (multipart/signed)]

[Attachment #4 (multipart/mixed)]


Hi,

On 28/08/15 04:39, Pinak Ahuja wrote:
> https://git.reviewboard.kde.org/r/124962/
> By Pinak Ahuja.
> 
> /Updated Aug. 28, 2015, 7:39 a.m./
> 
> *Repository: * kwallet-pam
> 
> pam_kwallet5.so was being installed to /lib(64) irrespective of what the
> installation prefix was set to. This patch fixes it.
> 
> pam_kwallet5.so seems to install under the directory set as CMAKE_INSTALL_PREFIX
> 
> 
>   * CMakeLists.txt (f60ac41)
> 
> View Diff <https://git.reviewboard.kde.org/r/124962/diff/>

Sorry that I haven't seen this review before plasma 5.5 was released
(containing this change), but pam modules are traditionally installed in /lib,
that is, with an empty prefix. In the same CMakeLists.txt you can read the
intention to honor this:
set_target_properties (${library_name} PROPERTIES PREFIX "")

Sadly, this alone is not sufficient, thus the / in the install rule.

This change forces me to introduce the attached patch in the Debian package,
as pam modules should be available even if /usr is not mounted.

Happy hacking,

["fix_install_location.diff" (text/x-diff)]

Index: kwallet-pam/CMakeLists.txt
===================================================================
--- kwallet-pam.orig/CMakeLists.txt	2015-12-10 14:12:47.823621683 +0100
+++ kwallet-pam/CMakeLists.txt	2015-12-10 20:45:45.967413893 +0100
@@ -36,7 +36,6 @@
 endif()
 
 add_library (${library_name} SHARED ${pam_kwallet_SRCS})
-set_target_properties (${library_name} PROPERTIES PREFIX "")
 target_link_libraries (${library_name}
    ${PAM_LIBRARIES}
    ${LIBGCRYPT_LIBRARIES}

["signature.asc" (application/pgp-signature)]
[Attachment #9 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]