'Re: Review Request 125891: calendar: Allow to scroll navigate in the entire DaysCalendar component'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 125891: calendar: Allow to scroll navigate in the entire DaysCalendar component
From:       "David Rosca" <nowrep () gmail ! com>
Date:       2015-10-31 19:29:33
Message-ID: 20151031192933.19145.27256 () mimi ! kde ! org
[Download RAW message or body]

--===============5929263808039488383==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

> On Oct. 31, 2015, 5:33 p.m., Thomas Pfeiffer wrote:
> > Thanks for adding usability!
> > I agree with Kai that the whole header area should be scrollable instead of just \
> > the label. One thing to make sure (if that is even affected by this change at \
> > all) is that when we have events in the poup, scrolling over the even description \
> > won't change the month. 
> > Other than that, +1 for the change!

This change makes the entire component (header + calendar view) scrollable.

> scrolling over the event description won't change the month.

Of course, but the code isn't there yet (at least I can't find it :).

- David

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125891/#review87784
-----------------------------------------------------------

On Oct. 31, 2015, 4:21 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125891/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2015, 4:21 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Allow to scroll navigate back/forward in DaysCalendar in the entire DaysCalendar \
> component, not just on header label. 
> 
> Diffs
> -----
> 
> src/declarativeimports/calendar/qml/DaysCalendar.qml a1d84d4 
> 
> Diff: https://git.reviewboard.kde.org/r/125891/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Rosca
> 
> 

--===============5929263808039488383==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/125891/">https://git.reviewboard.kde.org/r/125891/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On October 31st, 2015, 5:33 p.m. UTC, <b>Thomas \
Pfeiffer</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Thanks for adding usability! I agree with Kai that the \
whole header area should be scrollable instead of just the label. One thing to make \
sure (if that is even affected by this change at all) is that when we have events in \
the poup, scrolling over the even description won't change the month.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Other than that, +1 for the change!</p></pre>  </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This \
change makes the entire component (header + calendar view) scrollable.</p> \
<blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid \
#bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;"> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">scrolling over the event description won't change the month.</p> \
</blockquote> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Of course, but the code isn't there yet (at least I \
can't find it :).</p></pre> <br />

<p>- David</p>

<br />
<p>On October 31st, 2015, 4:21 p.m. UTC, David Rosca wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma and KDE Usability.</div>
<div>By David Rosca.</div>

<p style="color: grey;"><i>Updated Oct. 31, 2015, 4:21 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Allow to scroll navigate back/forward in DaysCalendar \
in the entire DaysCalendar component, not just on header label.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/declarativeimports/calendar/qml/DaysCalendar.qml <span style="color: \
grey">(a1d84d4)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/125891/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============5929263808039488383==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 