From kde-panel-devel Sat Oct 31 19:29:33 2015 From: "David Rosca" Date: Sat, 31 Oct 2015 19:29:33 +0000 To: kde-panel-devel Subject: Re: Review Request 125891: calendar: Allow to scroll navigate in the entire DaysCalendar component Message-Id: <20151031192933.19145.27256 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=144631981130703 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============9146383156050999522==" --===============9146383156050999522== Content-Type: multipart/alternative; boundary="===============5929263808039488383==" --===============5929263808039488383== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Oct. 31, 2015, 5:33 p.m., Thomas Pfeiffer wrote: > > Thanks for adding usability! > > I agree with Kai that the whole header area should be scrollable instead of just the label. > > One thing to make sure (if that is even affected by this change at all) is that when we have events in the poup, scrolling over the even description won't change the month. > > > > Other than that, +1 for the change! This change makes the entire component (header + calendar view) scrollable. > scrolling over the event description won't change the month. Of course, but the code isn't there yet (at least I can't find it :). - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125891/#review87784 ----------------------------------------------------------- On Oct. 31, 2015, 4:21 p.m., David Rosca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125891/ > ----------------------------------------------------------- > > (Updated Oct. 31, 2015, 4:21 p.m.) > > > Review request for Plasma and KDE Usability. > > > Repository: plasma-framework > > > Description > ------- > > Allow to scroll navigate back/forward in DaysCalendar in the entire DaysCalendar component, not just on header label. > > > Diffs > ----- > > src/declarativeimports/calendar/qml/DaysCalendar.qml a1d84d4 > > Diff: https://git.reviewboard.kde.org/r/125891/diff/ > > > Testing > ------- > > > Thanks, > > David Rosca > > --===============5929263808039488383== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125891/

On October 31st, 2015, 5:33 p.m. UTC, Thomas Pfeiffer wrote:

Thanks for adding usability! I agree with Kai that the whole header area should be scrollable instead of just the label. One thing to make sure (if that is even affected by this change at all) is that when we have events in the poup, scrolling over the even description won't change the month.

Other than that, +1 for the change!

This change makes the entire component (header + calendar view) scrollable.

scrolling over the event description won't change the month.

Of course, but the code isn't there yet (at least I can't find it :).

- David

On October 31st, 2015, 4:21 p.m. UTC, David Rosca wrote:

Review request for Plasma and KDE Usability.

By David Rosca.

Updated Oct. 31, 2015, 4:21 p.m.

Repository: plasma-framework

Description

Allow to scroll navigate back/forward in DaysCalendar in the entire DaysCalendar component, not just on header label.

Diffs

src/declarativeimports/calendar/qml/DaysCalendar.qml (a1d84d4)

--===============5929263808039488383==-- --===============9146383156050999522== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============9146383156050999522==--