'Re: Review Request 125662: mangonel: Initial port to Qt5/KF5'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 125662: mangonel: Initial port to Qt5/KF5
From:       "Martin Tobias Holmedahl Sandsmark" <martin.sandsmark () kde ! org>
Date:       2015-10-30 11:27:26
Message-ID: 20151030112726.27229.98833 () mimi ! kde ! org
[Download RAW message or body]

--===============0046417916090873398==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125662/#review87736
-----------------------------------------------------------

Ship it!

Ship It!

- Martin Tobias Holmedahl Sandsmark

On Oct. 16, 2015, 4:04 p.m., Jeremy Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125662/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2015, 4:04 p.m.)
> 
> 
> Review request for Plasma and Martin Tobias Holmedahl Sandsmark.
> 
> 
> Repository: mangonel
> 
> 
> Description
> -------
> 
> Port of Mangonel to Qt5/KF5
> 
> 
> Diffs
> -----
> 
> CMakeLists.txt fec95da 
> Label.cpp 136f70b 
> Mangonel.h 9c8a32f 
> Mangonel.cpp 63e10ab 
> main.cpp 1b0c4a3 
> providers/Applications.cpp 7674a97 
> providers/Paths.cpp 713aba3 
> 
> Diff: https://git.reviewboard.kde.org/r/125662/diff/
> 
> 
> Testing
> -------
> 
> It builds and runs, but looks a bit strange since it's a plani QWidget. (Maybe we \
> could say it's using Material design and call it good, dunno :p) 
> 
> File Attachments
> ----------------
> 
> screenshot
> https://git.reviewboard.kde.org/media/uploaded/files/2015/10/16/2f8f36d8-dea2-4679-8826-96ebbaa8c8e9__mangonel.png
>  
> 
> Thanks,
> 
> Jeremy Whiting
> 
> 

--===============0046417916090873398==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/125662/">https://git.reviewboard.kde.org/r/125662/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- Martin Tobias Holmedahl Sandsmark</p>

<br />
<p>On October 16th, 2015, 4:04 p.m. UTC, Jeremy Whiting wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma and Martin Tobias Holmedahl Sandsmark.</div>
<div>By Jeremy Whiting.</div>

<p style="color: grey;"><i>Updated Oct. 16, 2015, 4:04 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
mangonel
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Port of Mangonel to Qt5/KF5</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">It builds and runs, but looks a bit strange since it's \
a plani QWidget. (Maybe we could say it's using Material design and call it good, \
dunno :p)</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: grey">(fec95da)</span></li>

 <li>Label.cpp <span style="color: grey">(136f70b)</span></li>

 <li>Mangonel.h <span style="color: grey">(9c8a32f)</span></li>

 <li>Mangonel.cpp <span style="color: grey">(63e10ab)</span></li>

 <li>main.cpp <span style="color: grey">(1b0c4a3)</span></li>

 <li>providers/Applications.cpp <span style="color: grey">(7674a97)</span></li>

 <li>providers/Paths.cpp <span style="color: grey">(713aba3)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/125662/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/10/16/2f8f36d8-dea2-4679-8826-96ebbaa8c8e9__mangonel.png">screenshot</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============0046417916090873398==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 