[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 125878: fix lost QuickViewSharedEngine initialSize on initializing
From: "Aleix Pol Gonzalez" <aleixpol () kde ! org>
Date: 2015-10-30 10:31:46
Message-ID: 20151030103146.14097.4959 () mimi ! kde ! org
[Download RAW message or body]
--===============4216979118321502510==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125878/#review87734
-----------------------------------------------------------
+1
- Aleix Pol Gonzalez
On Oct. 30, 2015, 6:07 a.m., Takahiro Hashimoto wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125878/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2015, 6:07 a.m.)
>
>
> Review request for Plasma, David Edmundson and David Faure.
>
>
> Repository: kdeclarative
>
>
> Description
> -------
>
> After my commit 1c3f42afe17cc090372eaf45647d71495de12c19, view's initialiSize value \
> is lost (remaining 0,0 in spite of item's size). It should be set by item's size \
> for some reusing purpose (with initialSize() getter)
> Sorry again my bad commit :(
>
>
> Diffs
> -----
>
> src/quickaddons/quickviewsharedengine.cpp 323cf92
>
> Diff: https://git.reviewboard.kde.org/r/125878/diff/
>
>
> Testing
> -------
>
> build and run test
>
> kenya888@xps13 ~/devel/kf5/build/frameworks/kdeclarative $ ninja test
> [1/1] Running tests...
> Test project /home/kenya888/devel/kf5/build/frameworks/kdeclarative
> Start 1: fullmodelaccesstest
> 1/2 Test #1: fullmodelaccesstest .............. Passed 0.05 sec
> Start 2: quickviewsharedengine
> 2/2 Test #2: quickviewsharedengine ............ Passed 0.39 sec
>
> 100% tests passed, 0 tests failed out of 2
>
> Total Test time (real) = 0.44 sec
>
> ------
>
> confirmed ksplashqml works well which use QuickViewSharedEngine.
>
>
> Thanks,
>
> Takahiro Hashimoto
>
>
--===============4216979118321502510==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125878/">https://git.reviewboard.kde.org/r/125878/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">+1</p></pre> <br />
<p>- Aleix Pol Gonzalez</p>
<br />
<p>On October 30th, 2015, 6:07 a.m. CET, Takahiro Hashimoto wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma, David Edmundson and David Faure.</div>
<div>By Takahiro Hashimoto.</div>
<p style="color: grey;"><i>Updated Oct. 30, 2015, 6:07 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeclarative
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">After my commit \
1c3f42afe17cc090372eaf45647d71495de12c19, view's initialiSize value is lost \
(remaining 0,0 in spite of item's size). It should be set by item's size for some \
reusing purpose (with initialSize() getter) </p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Sorry again my bad \
commit :(</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">build and run test</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">kenya888@xps13 ~/devel/kf5/build/frameworks/kdeclarative $ ninja test [1/1] \
Running tests... Test project /home/kenya888/devel/kf5/build/frameworks/kdeclarative
Start 1: fullmodelaccesstest
1/2 Test #1: fullmodelaccesstest .............. Passed 0.05 sec
Start 2: quickviewsharedengine
2/2 Test #2: quickviewsharedengine ............ Passed 0.39 sec</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">100% tests passed, 0 tests failed out of 2</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Total Test time (real) = 0.44 sec</p> <hr style="text-rendering: \
inherit;margin: 0;padding: 0;white-space: normal;border: 1px solid #ddd;line-height: \
inherit;" /> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">confirmed ksplashqml works well which use \
QuickViewSharedEngine.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/quickaddons/quickviewsharedengine.cpp <span style="color: \
grey">(323cf92)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125878/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4216979118321502510==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic