[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 125395: Mutex around usage of m_connectedEvents which may be called from any thre
From: "David Edmundson" <david () davidedmundson ! co ! uk>
Date: 2015-09-30 11:08:42
Message-ID: 20150930110842.16344.1700 () mimi ! kde ! org
[Download RAW message or body]
--===============4277549988846806910==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125395/
-----------------------------------------------------------
(Updated Sept. 30, 2015, 11:08 a.m.)
Status
------
This change has been marked as submitted.
Review request for Plasma, Daniel Nicoletti and Harald Sitter.
Changes
-------
Submitted with commit 29247d6d19c49a20c17ea414a0e108905712a520 by David Edmundson to \
branch Applications/15.08.
Repository: print-manager
Description
-------
m_connectedEvents is modified in connectNotify which according to the
docs will be called from the thread of the caller, not this.
A mutex around all places that use/modify it should prevent print manager from making \
plasmashell crash.
BUG: 345862
Diffs
-----
libkcups/KCupsConnection.h f61ccb53078766e7f5e96dedec879b52b9083b66
libkcups/KCupsConnection.cpp 482a0bcc9afdee9e0fa131da158988d349dd0da6
Diff: https://git.reviewboard.kde.org/r/125395/diff/
Testing
-------
Applet still loads..though I don't have any printers, so can't test too much.
Thanks,
David Edmundson
--===============4277549988846806910==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125395/">https://git.reviewboard.kde.org/r/125395/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma, Daniel Nicoletti and Harald Sitter.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Sept. 30, 2015, 11:08 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 29247d6d19c49a20c17ea414a0e108905712a520 by David \
Edmundson to branch Applications/15.08.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
print-manager
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">m_connectedEvents is modified in connectNotify which \
according to the docs will be called from the thread of the caller, not this.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">A mutex around all places that use/modify it should \
prevent print manager from making plasmashell crash.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">BUG: \
345862</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Applet still loads..though I don't have any printers, \
so can't test too much.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libkcups/KCupsConnection.h <span style="color: \
grey">(f61ccb53078766e7f5e96dedec879b52b9083b66)</span></li>
<li>libkcups/KCupsConnection.cpp <span style="color: \
grey">(482a0bcc9afdee9e0fa131da158988d349dd0da6)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125395/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4277549988846806910==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic