--===============5501831792334984481== Content-Type: multipart/alternative; boundary="===============4277549988846806910==" --===============4277549988846806910== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125395/ ----------------------------------------------------------- (Updated Sept. 30, 2015, 11:08 a.m.) Status ------ This change has been marked as submitted. Review request for Plasma, Daniel Nicoletti and Harald Sitter. Changes ------- Submitted with commit 29247d6d19c49a20c17ea414a0e108905712a520 by David Edmundson to branch Applications/15.08. Repository: print-manager Description ------- m_connectedEvents is modified in connectNotify which according to the docs will be called from the thread of the caller, not this. A mutex around all places that use/modify it should prevent print manager from making plasmashell crash. BUG: 345862 Diffs ----- libkcups/KCupsConnection.h f61ccb53078766e7f5e96dedec879b52b9083b66 libkcups/KCupsConnection.cpp 482a0bcc9afdee9e0fa131da158988d349dd0da6 Diff: https://git.reviewboard.kde.org/r/125395/diff/ Testing ------- Applet still loads..though I don't have any printers, so can't test too much. Thanks, David Edmundson --===============4277549988846806910== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125395/

This change has been marked as submitted.

Review request for Plasma, Daniel Nicoletti and Harald Sitter.

By David Edmundson.

Updated Sept. 30, 2015, 11:08 a.m.

Changes

Submitted with commit 29247d6d19c49a20c17ea414a0e108905712a520 by David Edmundson to branch Applications/15.08.

Repository: print-manager

Description

m_connectedEvents is modified in connectNotify which according to the docs will be called from the thread of the caller, not this.

A mutex around all places that use/modify it should prevent print manager from making plasmashell crash.

BUG: 345862

Testing

Applet still loads..though I don't have any printers, so can't test too much.

Diffs

libkcups/KCupsConnection.h (f61ccb53078766e7f5e96dedec879b52b9083b66)
libkcups/KCupsConnection.cpp (482a0bcc9afdee9e0fa131da158988d349dd0da6)

View Diff

--===============4277549988846806910==-- --===============5501831792334984481== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============5501831792334984481==--