[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 125416: BugFix for "Bug 328807 - Removing sensor from graph causes KSysGuard cras
From: "Raphael Kugelmann" <raphael.ku () gmx ! de>
Date: 2015-09-29 18:29:31
Message-ID: 20150929182931.16344.40599 () mimi ! kde ! org
[Download RAW message or body]
--===============7635992984839547916==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Sept. 28, 2015, 8:37 vorm., Marco Martin wrote:
> > Ship It!
Hi,
I have no commit rights.
please commit it.
Thanks!
- Raphael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125416/#review86031
-----------------------------------------------------------
On Sept. 26, 2015, 11:05 nachm., Raphael Kugelmann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125416/
> -----------------------------------------------------------
>
> (Updated Sept. 26, 2015, 11:05 nachm.)
>
>
> Review request for Plasma.
>
>
> Repository: ksysguard
>
>
> Description
> -------
>
> BugFix for "Bug 328807 - Removing sensor from graph causes KSysGuard crash" \
> (affected SensorType: DancingBars)
> https://bugs.kde.org/show_bug.cgi?id=328807
>
> Two issues fixed:
> - crash during removing a bar Sensor
> - wrong Sensors is removed
> - labels are not set as expected after removing a bar
>
>
> Diffs
> -----
>
> gui/SensorDisplayLib/BarGraph.cpp ecd6674ea4f66c3c061feb31c6a68e2e7abed885
> gui/SensorDisplayLib/DancingBars.cpp 13c8a45f4f4ca9dd16f62cdf6295bcd6643d2a12
> gui/SensorDisplayLib/DancingBarsSettings.h 27df0666db53621ecddb2e4763b26509103f7381 \
> gui/SensorDisplayLib/DancingBarsSettings.cpp \
> 6eb9c21b1670b028570e3826620b98e07eac266d
> Diff: https://git.reviewboard.kde.org/r/125416/diff/
>
>
> Testing
> -------
>
> Tested
> - no crash anymore
> - the remaining sensors are the one as expected
>
>
> Thanks,
>
> Raphael Kugelmann
>
>
--===============7635992984839547916==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125416/">https://git.reviewboard.kde.org/r/125416/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On September 28th, 2015, 8:37 vorm. UTC, <b>Marco \
Martin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Ship It!</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hi, I \
have no commit rights. please commit it.
Thanks!</p></pre>
<br />
<p>- Raphael</p>
<br />
<p>On September 26th, 2015, 11:05 nachm. UTC, Raphael Kugelmann wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Raphael Kugelmann.</div>
<p style="color: grey;"><i>Updated Sept. 26, 2015, 11:05 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ksysguard
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">BugFix for "Bug 328807 - Removing sensor from graph \
causes KSysGuard crash" (affected SensorType: DancingBars)</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">https://bugs.kde.org/show_bug.cgi?id=328807</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Two \
issues fixed:
- crash during removing a bar Sensor
- wrong Sensors is removed
- labels are not set as expected after removing a bar</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tested
- no crash anymore
- the remaining sensors are the one as expected</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>gui/SensorDisplayLib/BarGraph.cpp <span style="color: \
grey">(ecd6674ea4f66c3c061feb31c6a68e2e7abed885)</span></li>
<li>gui/SensorDisplayLib/DancingBars.cpp <span style="color: \
grey">(13c8a45f4f4ca9dd16f62cdf6295bcd6643d2a12)</span></li>
<li>gui/SensorDisplayLib/DancingBarsSettings.h <span style="color: \
grey">(27df0666db53621ecddb2e4763b26509103f7381)</span></li>
<li>gui/SensorDisplayLib/DancingBarsSettings.cpp <span style="color: \
grey">(6eb9c21b1670b028570e3826620b98e07eac266d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125416/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7635992984839547916==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic