From kde-panel-devel Tue Sep 29 18:29:31 2015 From: "Raphael Kugelmann" Date: Tue, 29 Sep 2015 18:29:31 +0000 To: kde-panel-devel Subject: Re: Review Request 125416: BugFix for "Bug 328807 - Removing sensor from graph causes KSysGuard cras Message-Id: <20150929182931.16344.40599 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=144355138426976 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============7711792139323140503==" --===============7711792139323140503== Content-Type: multipart/alternative; boundary="===============7635992984839547916==" --===============7635992984839547916== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Sept. 28, 2015, 8:37 vorm., Marco Martin wrote: > > Ship It! Hi, I have no commit rights. please commit it. Thanks! - Raphael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125416/#review86031 ----------------------------------------------------------- On Sept. 26, 2015, 11:05 nachm., Raphael Kugelmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125416/ > ----------------------------------------------------------- > > (Updated Sept. 26, 2015, 11:05 nachm.) > > > Review request for Plasma. > > > Repository: ksysguard > > > Description > ------- > > BugFix for "Bug 328807 - Removing sensor from graph causes KSysGuard crash" (affected SensorType: DancingBars) > > https://bugs.kde.org/show_bug.cgi?id=328807 > > Two issues fixed: > - crash during removing a bar Sensor > - wrong Sensors is removed > - labels are not set as expected after removing a bar > > > Diffs > ----- > > gui/SensorDisplayLib/BarGraph.cpp ecd6674ea4f66c3c061feb31c6a68e2e7abed885 > gui/SensorDisplayLib/DancingBars.cpp 13c8a45f4f4ca9dd16f62cdf6295bcd6643d2a12 > gui/SensorDisplayLib/DancingBarsSettings.h 27df0666db53621ecddb2e4763b26509103f7381 > gui/SensorDisplayLib/DancingBarsSettings.cpp 6eb9c21b1670b028570e3826620b98e07eac266d > > Diff: https://git.reviewboard.kde.org/r/125416/diff/ > > > Testing > ------- > > Tested > - no crash anymore > - the remaining sensors are the one as expected > > > Thanks, > > Raphael Kugelmann > > --===============7635992984839547916== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125416/

On September 28th, 2015, 8:37 vorm. UTC, Marco Martin wrote:
Ship It!

Hi, I have no commit rights. please commit it. Thanks!

- Raphael

On September 26th, 2015, 11:05 nachm. UTC, Raphael Kugelmann wrote:

Review request for Plasma.

By Raphael Kugelmann.

Updated Sept. 26, 2015, 11:05 nachm.

Repository: ksysguard

Description

BugFix for "Bug 328807 - Removing sensor from graph causes KSysGuard crash" (affected SensorType: DancingBars)

https://bugs.kde.org/show_bug.cgi?id=328807

Two issues fixed: - crash during removing a bar Sensor - wrong Sensors is removed - labels are not set as expected after removing a bar

Testing

Tested - no crash anymore - the remaining sensors are the one as expected

Diffs

gui/SensorDisplayLib/BarGraph.cpp (ecd6674ea4f66c3c061feb31c6a68e2e7abed885)
gui/SensorDisplayLib/DancingBars.cpp (13c8a45f4f4ca9dd16f62cdf6295bcd6643d2a12)
gui/SensorDisplayLib/DancingBarsSettings.h (27df0666db53621ecddb2e4763b26509103f7381)
gui/SensorDisplayLib/DancingBarsSettings.cpp (6eb9c21b1670b028570e3826620b98e07eac266d)

--===============7635992984839547916==-- --===============7711792139323140503== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============7711792139323140503==--