'Re: Review Request 125445: [libtaskmanager] Protect against X11 usage on Wayland'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 125445: [libtaskmanager] Protect against X11 usage on Wayland
From:       Martin_Gräßlin <mgraesslin () kde ! org>
Date:       2015-09-29 14:24:51
Message-ID: 20150929142451.16344.92237 () mimi ! kde ! org
[Download RAW message or body]

--===============3768751077750437623==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125445/
-----------------------------------------------------------

(Updated Sept. 29, 2015, 2:24 p.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma and Eike Hein.

Changes
-------

Submitted with commit 3927e62e19a86dddc7e1c1d2a469a3d5ebbabe9c by Martin Gräßlin to \
branch master.

Repository: plasma-workspace

Description
-------

Libtaskmanager so far only has compile time checks for windowing
systems resulting in the X11 specific code to be executed on platform
wayland which of course causes crashers.

This is a workaround by at least ensuring that we only call X11 specific
code on platform X11.

Diffs
-----

  libtaskmanager/task_p.h 047ed769dfb1c8eaec58196df8a3b44533562f27 
  libtaskmanager/task_x11.cpp 7c342c64e1604202e3747983692e3c8de20b7e77 

Diff: https://git.reviewboard.kde.org/r/125445/diff/

Testing
-------

Thanks,

Martin Gräßlin

--===============3768751077750437623==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/125445/">https://git.reviewboard.kde.org/r/125445/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma and Eike Hein.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated Sept. 29, 2015, 2:24 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 3927e62e19a86dddc7e1c1d2a469a3d5ebbabe9c by Martin \
Gräßlin to branch master.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Libtaskmanager so far only has compile time checks for windowing systems \
resulting in the X11 specific code to be executed on platform wayland which of course \
causes crashers.

This is a workaround by at least ensuring that we only call X11 specific
code on platform X11.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>libtaskmanager/task_p.h <span style="color: \
grey">(047ed769dfb1c8eaec58196df8a3b44533562f27)</span></li>

 <li>libtaskmanager/task_x11.cpp <span style="color: \
grey">(7c342c64e1604202e3747983692e3c8de20b7e77)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/125445/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============3768751077750437623==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 