From kde-panel-devel Tue Sep 29 14:24:51 2015 From: =?utf-8?q?Martin_Gr=C3=A4=C3=9Flin?= Date: Tue, 29 Sep 2015 14:24:51 +0000 To: kde-panel-devel Subject: Re: Review Request 125445: [libtaskmanager] Protect against X11 usage on Wayland Message-Id: <20150929142451.16344.92237 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=144353675321885 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============2935749021550260597==" --===============2935749021550260597== Content-Type: multipart/alternative; boundary="===============3768751077750437623==" --===============3768751077750437623== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125445/ ----------------------------------------------------------- (Updated Sept. 29, 2015, 2:24 p.m.) Status ------ This change has been marked as submitted. Review request for Plasma and Eike Hein. Changes ------- Submitted with commit 3927e62e19a86dddc7e1c1d2a469a3d5ebbabe9c by Martin Gräßlin to branch master. Repository: plasma-workspace Description ------- Libtaskmanager so far only has compile time checks for windowing systems resulting in the X11 specific code to be executed on platform wayland which of course causes crashers. This is a workaround by at least ensuring that we only call X11 specific code on platform X11. Diffs ----- libtaskmanager/task_p.h 047ed769dfb1c8eaec58196df8a3b44533562f27 libtaskmanager/task_x11.cpp 7c342c64e1604202e3747983692e3c8de20b7e77 Diff: https://git.reviewboard.kde.org/r/125445/diff/ Testing ------- Thanks, Martin Gräßlin --===============3768751077750437623== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125445/

This change has been marked as submitted.

Review request for Plasma and Eike Hein.

By Martin Gräßlin.

Updated Sept. 29, 2015, 2:24 p.m.

Changes

Submitted with commit 3927e62e19a86dddc7e1c1d2a469a3d5ebbabe9c by Martin Gräßlin to branch master.

Repository: plasma-workspace

Description

Libtaskmanager so far only has compile time checks for windowing
systems resulting in the X11 specific code to be executed on platform
wayland which of course causes crashers.

This is a workaround by at least ensuring that we only call X11 specific
code on platform X11.

Diffs

libtaskmanager/task_p.h (047ed769dfb1c8eaec58196df8a3b44533562f27)
libtaskmanager/task_x11.cpp (7c342c64e1604202e3747983692e3c8de20b7e77)

View Diff

--===============3768751077750437623==-- --===============2935749021550260597== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============2935749021550260597==--