[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 122510: [screenlocker] Mark session as idle in logind while screen is locked
From: Martin_Gräßlin <mgraesslin () kde ! org>
Date: 2015-09-29 7:37:00
Message-ID: 20150929073700.8863.17944 () mimi ! kde ! org
[Download RAW message or body]
--===============8115107970252129736==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122510/
-----------------------------------------------------------
(Updated Sept. 29, 2015, 9:37 a.m.)
Status
------
This change has been discarded.
Review request for Plasma.
Bugs: 271731
https://bugs.kde.org/show_bug.cgi?id=271731
Repository: plasma-workspace
Description
-------
See the idle recommendations on [1]. Binding it to the lock screen does
not exactly match the recommendation, but it has some advantages:
* we know it's idle when it's locked
* it kicks in after the user's configured idle timeout
* if the user unlocks we know it's no longer idle
FEATURE: 271731
FIXED-IN: 5.3.0
[1] http://www.freedesktop.org/wiki/Software/systemd/writing-desktop-environments/
Diffs
-----
ksmserver/screenlocker/ksldapp.cpp e23b50fbcaac659bb6ef1b36a4de6efc63573978
ksmserver/screenlocker/logind.h 99836734923740a1f0b23144f9effd815f104b74
ksmserver/screenlocker/logind.cpp 5335b150bce8f38aee75ad30055bc0e248ed1bf1
Diff: https://git.reviewboard.kde.org/r/122510/diff/
Testing
-------
Run the test application and verified using loginctl from tty1 while the screen was \
locked and after unlocked.
Thanks,
Martin Gräßlin
--===============8115107970252129736==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122510/">https://git.reviewboard.kde.org/r/122510/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Sept. 29, 2015, 9:37 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=271731">271731</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">See the idle recommendations on [1]. Binding it to the \
lock screen does not exactly match the recommendation, but it has some advantages:
* we know it's idle when it's locked
* it kicks in after the user's configured idle timeout
* if the user unlocks we know it's no longer idle</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">FEATURE: 271731
FIXED-IN: 5.3.0</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">[1] \
http://www.freedesktop.org/wiki/Software/systemd/writing-desktop-environments/</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Run the test application and verified using loginctl \
from tty1 while the screen was locked and after unlocked.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ksmserver/screenlocker/ksldapp.cpp <span style="color: \
grey">(e23b50fbcaac659bb6ef1b36a4de6efc63573978)</span></li>
<li>ksmserver/screenlocker/logind.h <span style="color: \
grey">(99836734923740a1f0b23144f9effd815f104b74)</span></li>
<li>ksmserver/screenlocker/logind.cpp <span style="color: \
grey">(5335b150bce8f38aee75ad30055bc0e248ed1bf1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122510/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8115107970252129736==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic