--===============0730021370807949466== Content-Type: multipart/alternative; boundary="===============8115107970252129736==" --===============8115107970252129736== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122510/ ----------------------------------------------------------- (Updated Sept. 29, 2015, 9:37 a.m.) Status ------ This change has been discarded. Review request for Plasma. Bugs: 271731 https://bugs.kde.org/show_bug.cgi?id=271731 Repository: plasma-workspace Description ------- See the idle recommendations on [1]. Binding it to the lock screen does not exactly match the recommendation, but it has some advantages: * we know it's idle when it's locked * it kicks in after the user's configured idle timeout * if the user unlocks we know it's no longer idle FEATURE: 271731 FIXED-IN: 5.3.0 [1] http://www.freedesktop.org/wiki/Software/systemd/writing-desktop-environments/ Diffs ----- ksmserver/screenlocker/ksldapp.cpp e23b50fbcaac659bb6ef1b36a4de6efc63573978 ksmserver/screenlocker/logind.h 99836734923740a1f0b23144f9effd815f104b74 ksmserver/screenlocker/logind.cpp 5335b150bce8f38aee75ad30055bc0e248ed1bf1 Diff: https://git.reviewboard.kde.org/r/122510/diff/ Testing ------- Run the test application and verified using loginctl from tty1 while the screen was locked and after unlocked. Thanks, Martin Gräßlin --===============8115107970252129736== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122510/

This change has been discarded.

Review request for Plasma.
By Martin Gräßlin.

Updated Sept. 29, 2015, 9:37 a.m.

Bugs: 271731
Repository: plasma-workspace

Description 

See the idle recommendations on [1]. Binding it to the lock screen does
not exactly match the recommendation, but it has some advantages:
* we know it's idle when it's locked
* it kicks in after the user's configured idle timeout
* if the user unlocks we know it's no longer idle


FEATURE: 271731
FIXED-IN: 5.3.0


[1] http://www.freedesktop.org/wiki/Software/systemd/writing-desktop-environments/

Testing 

Run the test application and verified using loginctl from tty1 while the screen was locked and after unlocked.

Diffs

  • ksmserver/screenlocker/ksldapp.cpp (e23b50fbcaac659bb6ef1b36a4de6efc63573978)
  • ksmserver/screenlocker/logind.h (99836734923740a1f0b23144f9effd815f104b74)
  • ksmserver/screenlocker/logind.cpp (5335b150bce8f38aee75ad30055bc0e248ed1bf1)

View Diff
--===============8115107970252129736==-- --===============0730021370807949466== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============0730021370807949466==--