[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 125323: Continue even if script returns errors
From: "Siddhartha Sahu" <sh.siddhartha () gmail ! com>
Date: 2015-09-28 19:24:56
Message-ID: 20150928192456.8863.24252 () mimi ! kde ! org
[Download RAW message or body]
--===============6187698279725976816==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125323/#review86067
-----------------------------------------------------------
The scripts are being sourced in a subshell, so echo will work, but the sourced \
variabled are then discarded.
It should be `test -r "$file" && . "$file" || true` (lets use `true` instead of `:` \
for better clarity?)
- Siddhartha Sahu
On Sept. 20, 2015, 9:29 p.m., Steven Franzen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125323/
> -----------------------------------------------------------
>
> (Updated Sept. 20, 2015, 9:29 p.m.)
>
>
> Review request for Plasma and Luca Beltrame.
>
>
> Bugs: 352491
> https://bugs.kde.org/show_bug.cgi?id=352491
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> /bin/sh stops execution upon finding a nonzero exit code, which means that startkde \
> will not continue if a script in .config/plasma-workspace/env/ produces an error. \
> This small fix will execute a no-op in such a case, so that errors will not affect \
> startkde's progress, while still being visible in .xsession-errors.
>
> Diffs
> -----
>
> startkde/startkde.cmake 8948489c63c1bce0974bd2b3ce83515b1870af3a
>
> Diff: https://git.reviewboard.kde.org/r/125323/diff/
>
>
> Testing
> -------
>
> Tested both env-old.sh and env-new.sh with envvars.sh in ./testing, which refers to \
> a location that no longer exists on my system. Confirmed that only env-new.sh \
> performs the echo at the end.
>
> File Attachments
> ----------------
>
> The current section from startkde
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/20/3ac48cee-7656-48dc-9cb9-c119c93a87da__env-old.sh
> The fix
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/20/f40c8612-27d0-4df0-a53f-47f5ff8220a1__env-new.sh
> Script from the bug report
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/20/87cf8534-2a6a-42b1-8f6c-c8f59f4a8537__envvars.sh
>
>
> Thanks,
>
> Steven Franzen
>
>
--===============6187698279725976816==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125323/">https://git.reviewboard.kde.org/r/125323/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The \
scripts are being sourced in a subshell, so echo will work, but the sourced variabled \
are then discarded.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">It should be <code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">test -r "$file" && . "$file" || true</code> (lets \
use <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: \
normal;margin: 0;line-height: inherit;">true</code> instead of <code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">:</code> for better clarity?)</p></pre> <br />
<p>- Siddhartha Sahu</p>
<br />
<p>On September 20th, 2015, 9:29 p.m. IST, Steven Franzen wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma and Luca Beltrame.</div>
<div>By Steven Franzen.</div>
<p style="color: grey;"><i>Updated Sept. 20, 2015, 9:29 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=352491">352491</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">/bin/sh stops execution upon finding a nonzero exit \
code, which means that startkde will not continue if a script in \
.config/plasma-workspace/env/ produces an error. This small fix will execute a no-op \
in such a case, so that errors will not affect startkde's progress, while still being \
visible in .xsession-errors.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tested both env-old.sh and env-new.sh with envvars.sh \
in ./testing, which refers to a location that no longer exists on my system. \
Confirmed that only env-new.sh performs the echo at the end.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>startkde/startkde.cmake <span style="color: \
grey">(8948489c63c1bce0974bd2b3ce83515b1870af3a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125323/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/09/20/3ac48cee-7656-48dc-9cb9-c119c93a87da__env-old.sh">The \
current section from startkde</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/09/20/f40c8612-27d0-4df0-a53f-47f5ff8220a1__env-new.sh">The \
fix</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/09/20/87cf8534-2a6a-42b1-8f6c-c8f59f4a8537__envvars.sh">Script \
from the bug report</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6187698279725976816==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic