From kde-panel-devel Mon Sep 28 19:24:56 2015 From: "Siddhartha Sahu" Date: Mon, 28 Sep 2015 19:24:56 +0000 To: kde-panel-devel Subject: Re: Review Request 125323: Continue even if script returns errors Message-Id: <20150928192456.8863.24252 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=144346832004387 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============0671510944509504131==" --===============0671510944509504131== Content-Type: multipart/alternative; boundary="===============6187698279725976816==" --===============6187698279725976816== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125323/#review86067 ----------------------------------------------------------- The scripts are being sourced in a subshell, so echo will work, but the sourced variabled are then discarded. It should be `test -r "$file" && . "$file" || true` (lets use `true` instead of `:` for better clarity?) - Siddhartha Sahu On Sept. 20, 2015, 9:29 p.m., Steven Franzen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125323/ > ----------------------------------------------------------- > > (Updated Sept. 20, 2015, 9:29 p.m.) > > > Review request for Plasma and Luca Beltrame. > > > Bugs: 352491 > https://bugs.kde.org/show_bug.cgi?id=352491 > > > Repository: plasma-workspace > > > Description > ------- > > /bin/sh stops execution upon finding a nonzero exit code, which means that startkde will not continue if a script in .config/plasma-workspace/env/ produces an error. This small fix will execute a no-op in such a case, so that errors will not affect startkde's progress, while still being visible in .xsession-errors. > > > Diffs > ----- > > startkde/startkde.cmake 8948489c63c1bce0974bd2b3ce83515b1870af3a > > Diff: https://git.reviewboard.kde.org/r/125323/diff/ > > > Testing > ------- > > Tested both env-old.sh and env-new.sh with envvars.sh in ./testing, which refers to a location that no longer exists on my system. Confirmed that only env-new.sh performs the echo at the end. > > > File Attachments > ---------------- > > The current section from startkde > https://git.reviewboard.kde.org/media/uploaded/files/2015/09/20/3ac48cee-7656-48dc-9cb9-c119c93a87da__env-old.sh > The fix > https://git.reviewboard.kde.org/media/uploaded/files/2015/09/20/f40c8612-27d0-4df0-a53f-47f5ff8220a1__env-new.sh > Script from the bug report > https://git.reviewboard.kde.org/media/uploaded/files/2015/09/20/87cf8534-2a6a-42b1-8f6c-c8f59f4a8537__envvars.sh > > > Thanks, > > Steven Franzen > > --===============6187698279725976816== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125323/ 

The scripts are being sourced in a subshell, so echo will work, but the sourced variabled are then discarded.


It should be test -r "$file" && . "$file" || true (lets use true instead of : for better clarity?)

- Siddhartha Sahu


On September 20th, 2015, 9:29 p.m. IST, Steven Franzen wrote:

Review request for Plasma and Luca Beltrame.
By Steven Franzen.

Updated Sept. 20, 2015, 9:29 p.m.

Bugs: 352491
Repository: plasma-workspace

Description 

/bin/sh stops execution upon finding a nonzero exit code, which means that startkde will not continue if a script in .config/plasma-workspace/env/ produces an error. This small fix will execute a no-op in such a case, so that errors will not affect startkde's progress, while still being visible in .xsession-errors.

Testing 

Tested both env-old.sh and env-new.sh with envvars.sh in ./testing, which refers to a location that no longer exists on my system. Confirmed that only env-new.sh performs the echo at the end.

Diffs

  • startkde/startkde.cmake (8948489c63c1bce0974bd2b3ce83515b1870af3a)

View Diff

File Attachments

  • The current section from startkde
  • The fix
  • Script from the bug report
    		•
    --===============6187698279725976816==-- --===============0671510944509504131== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============0671510944509504131==--