[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 112727: Shrink (fancy) unhide trigger when entered while FS window is active
From: Thomas_Lübking <thomas.luebking () gmail ! com>
Date: 2015-09-28 7:23:32
Message-ID: 20150928072332.8863.52421 () mimi ! kde ! org
[Download RAW message or body]
--===============6555027972503798213==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/112727/
-----------------------------------------------------------
(Updated Sept. 28, 2015, 7:23 vorm.)
Status
------
This change has been discarded.
Review request for Plasma, Aaron J. Seigo and Martin Gräßlin.
Bugs: 217560
http://bugs.kde.org/show_bug.cgi?id=217560
Repository: kde-workspace
Description
-------
Drawback: the next trigger will go unfancied (would require listening to active \
window changes, no idea whether that's acceptable) but that's still much better than \
occluding 30 outer px of a window (see bug and \
http://forum.kde.org/viewtopic.php?f=111&t=112163)
Notice that
a) nor auto unhiding neither hinting happens at all while there's a(n active) \
fullscreen window - this is unchanged (see early exit in patched branch) b) the patch \
does nothing if you don't attempt to enter the occluded area of a fullscreen window \
(so not even the next hinting will be affected)
Diffs
-----
plasma/desktop/shell/panelview.cpp dcd051a
Diff: https://git.reviewboard.kde.org/r/112727/diff/
Testing
-------
m_unhideTrigger shrinks and the next unhide is not indicated (but the panel appears), \
subsequent indication remains unaffected.
Thanks,
Thomas Lübking
--===============6555027972503798213==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/112727/">https://git.reviewboard.kde.org/r/112727/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma, Aaron J. Seigo and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Sept. 28, 2015, 7:23 vorm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=217560">217560</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Drawback: the next trigger will go unfancied (would require listening to \
active window changes, no idea whether that's acceptable) but that's still \
much better than occluding 30 outer px of a window (see bug and \
http://forum.kde.org/viewtopic.php?f=111&t=112163)
Notice that
a) nor auto unhiding neither hinting happens at all while there's a(n active) \
fullscreen window - this is unchanged (see early exit in patched branch) b) the patch \
does nothing if you don't attempt to enter the occluded area of a fullscreen \
window (so not even the next hinting will be affected)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">m_unhideTrigger shrinks and the next unhide is not indicated (but the \
panel appears), subsequent indication remains unaffected.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/desktop/shell/panelview.cpp <span style="color: \
grey">(dcd051a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/112727/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6555027972503798213==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic