[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 125420: Load the mimetype file lowercase name
From: "David Faure" <faure () kde ! org>
Date: 2015-09-28 7:19:07
Message-ID: 20150928071907.8863.70701 () mimi ! kde ! org
[Download RAW message or body]
--===============4957823160721299166==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125420/#review86027
-----------------------------------------------------------
keditfiletype/mimetypedata.cpp (line 94)
<https://git.reviewboard.kde.org/r/125420/#comment59355>
This is only true since shared-mime-info 1.3 though.
So there should be a fallback lookup like I did in qtbase \
4ccf5c6f4a411d367749565323f7c7fd469b025e
keditfiletype/mimetypedata.cpp (line 118)
<https://git.reviewboard.kde.org/r/125420/#comment59356>
or faster,
QString::compare(mimeName, name(), Qt::CaseInsensitive) != 0
- David Faure
On Sept. 27, 2015, 2:59 p.m., Albert Astals Cid wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125420/
> -----------------------------------------------------------
>
> (Updated Sept. 27, 2015, 2:59 p.m.)
>
>
> Review request for Plasma and David Faure.
>
>
> Repository: kde-cli-tools
>
>
> Description
> -------
>
> Since update-mime-database writes them in lowercase.
>
> Also only complain if the names don't match in lowercase since mime names are case \
> unsensitive.
>
> Diffs
> -----
>
> keditfiletype/mimetypedata.cpp ecef70d
>
> Diff: https://git.reviewboard.kde.org/r/125420/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Albert Astals Cid
>
>
--===============4957823160721299166==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125420/">https://git.reviewboard.kde.org/r/125420/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/125420/diff/1/?file=408549#file408549line94" \
style="color: black; font-weight: bold; text-decoration: \
underline;">keditfiletype/mimetypedata.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
MimeTypeData::initFromQMimeType()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">94</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">const</span> <span class="n">QString</span> <span class="n">file</span> \
<span class="o">=</span> <span class="n">name</span><span class="p">()</span> <span \
class="o">+</span> <span class="n">QLatin1String</span><span class="p">(</span><span \
class="s">".xml"</span><span class="p">);</span></pre></td> <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">94</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">const</span> <span class="n">QString</span> <span class="n">file</span> \
<span class="o">=</span> <span class="n">name</span><span class="p">()<span \
class="hl">.</span></span><span class="n"><span class="hl">toLower</span></span><span \
class="p"><span class="hl">()</span></span> <span class="o">+</span> <span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">".xml"</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This \
is only true since shared-mime-info 1.3 though.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">So \
there should be a fallback lookup like I did in qtbase \
4ccf5c6f4a411d367749565323f7c7fd469b025e</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/125420/diff/1/?file=408549#file408549line118" \
style="color: black; font-weight: bold; text-decoration: \
underline;">keditfiletype/mimetypedata.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
MimeTypeData::initFromQMimeType()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">118</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">if</span> <span class="p">(</span><span class="n">mimeName</span> <span \
class="o">!=</span> <span class="n">name</span><span class="p">())</span> <span \
class="p">{</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">118</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span \
class="p">(</span><span class="n">mimeName</span><span class="p"><span \
class="hl">.</span></span><span class="n"><span class="hl">toLower</span></span><span \
class="p"><span class="hl">()</span></span> <span class="o">!=</span> <span \
class="n">name</span><span class="p">()<span class="hl">.</span></span><span \
class="n"><span class="hl">toLower</span></span><span class="p"><span \
class="hl">()</span>)</span> <span class="p">{</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">or \
faster, QString::compare(mimeName, name(), Qt::CaseInsensitive) != 0</p></pre>
</div>
</div>
<br />
<p>- David Faure</p>
<br />
<p>On September 27th, 2015, 2:59 p.m. UTC, Albert Astals Cid wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma and David Faure.</div>
<div>By Albert Astals Cid.</div>
<p style="color: grey;"><i>Updated Sept. 27, 2015, 2:59 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-cli-tools
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Since update-mime-database writes them in \
lowercase.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Also only complain if the names don't match in \
lowercase since mime names are case unsensitive.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>keditfiletype/mimetypedata.cpp <span style="color: grey">(ecef70d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125420/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4957823160721299166==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic