[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 108798: Fix most of the compile issues due to wrong header used and comment out i
From: "Shawn Starr" <shawn.starr () rogers ! com>
Date: 2015-08-31 21:17:32
Message-ID: 20150831211732.10622.30196 () mimi ! kde ! org
[Download RAW message or body]
--===============2018349722394375675==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/108798/
-----------------------------------------------------------
(Updated Aug. 31, 2015, 9:17 p.m.)
Status
------
This change has been discarded.
Review request for Plasma, Aaron J. Seigo and Marco Martin.
Repository: plasma-framework
Description
-------
Trying to build plasma-framework I encountered some headers using 3rd party names vs \
internal and I believe these should all be internal headers? Fixing those and \
commenting out one of the testcase apps gets it to build. Although there's other \
issues with not linking kdecore/ui etc properly. Given this code is in heavy \
development, you may disregard this review request but I'd still like to go though \
the process.
btw, I'm back ;)
Diffs
-----
scriptengines/qml/common/scriptenv.cpp b79cd3d
declarativeimports/core/framesvgitem.h fb4741a
scriptengines/qml/declarative/packageaccessmanager.h 3e9a712
scriptengines/qml/declarative/packageaccessmanagerfactory.h 70e4eb9
scriptengines/qml/plasmoid/abstractjsappletscript.h cdd709c
scriptengines/qml/plasmoid/appletauthorization.cpp 6fe9454
scriptengines/qml/plasmoid/appletinterface.h 6226802
scriptengines/qml/plasmoid/appletinterface.cpp f5dc187
scriptengines/qml/plasmoid/declarativeappletscript.h 18b324b
scriptengines/qml/plasmoid/declarativeappletscript.cpp 75d25eb
shell/CMakeLists.txt ecbfad9
Diff: https://git.reviewboard.kde.org/r/108798/diff/
Testing
-------
Able to build things, but didn't look into why proper KDE libraries not being linked \
in yet (editing the generated CMakefiles/component.dir/link.txt works around this for \
now)
Thanks,
Shawn Starr
--===============2018349722394375675==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/108798/">https://git.reviewboard.kde.org/r/108798/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma, Aaron J. Seigo and Marco Martin.</div>
<div>By Shawn Starr.</div>
<p style="color: grey;"><i>Updated Aug. 31, 2015, 9:17 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Trying to build plasma-framework I encountered some headers using 3rd \
party names vs internal and I believe these should all be internal headers? Fixing \
those and commenting out one of the testcase apps gets it to build. Although \
there's other issues with not linking kdecore/ui etc properly. Given this code is \
in heavy development, you may disregard this review request but I'd still like to \
go though the process.
btw, I'm back ;)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Able to build things, but didn't look into why proper KDE libraries \
not being linked in yet (editing the generated CMakefiles/component.dir/link.txt \
works around this for now)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>scriptengines/qml/common/scriptenv.cpp <span style="color: \
grey">(b79cd3d)</span></li>
<li>declarativeimports/core/framesvgitem.h <span style="color: \
grey">(fb4741a)</span></li>
<li>scriptengines/qml/declarative/packageaccessmanager.h <span style="color: \
grey">(3e9a712)</span></li>
<li>scriptengines/qml/declarative/packageaccessmanagerfactory.h <span style="color: \
grey">(70e4eb9)</span></li>
<li>scriptengines/qml/plasmoid/abstractjsappletscript.h <span style="color: \
grey">(cdd709c)</span></li>
<li>scriptengines/qml/plasmoid/appletauthorization.cpp <span style="color: \
grey">(6fe9454)</span></li>
<li>scriptengines/qml/plasmoid/appletinterface.h <span style="color: \
grey">(6226802)</span></li>
<li>scriptengines/qml/plasmoid/appletinterface.cpp <span style="color: \
grey">(f5dc187)</span></li>
<li>scriptengines/qml/plasmoid/declarativeappletscript.h <span style="color: \
grey">(18b324b)</span></li>
<li>scriptengines/qml/plasmoid/declarativeappletscript.cpp <span style="color: \
grey">(75d25eb)</span></li>
<li>shell/CMakeLists.txt <span style="color: grey">(ecbfad9)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/108798/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2018349722394375675==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic