From kde-panel-devel Mon Aug 31 21:17:32 2015 From: "Shawn Starr" Date: Mon, 31 Aug 2015 21:17:32 +0000 To: kde-panel-devel Subject: Re: Review Request 108798: Fix most of the compile issues due to wrong header used and comment out i Message-Id: <20150831211732.10622.30196 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=144105587604317 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1079221895079155865==" --===============1079221895079155865== Content-Type: multipart/alternative; boundary="===============2018349722394375675==" --===============2018349722394375675== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/108798/ ----------------------------------------------------------- (Updated Aug. 31, 2015, 9:17 p.m.) Status ------ This change has been discarded. Review request for Plasma, Aaron J. Seigo and Marco Martin. Repository: plasma-framework Description ------- Trying to build plasma-framework I encountered some headers using 3rd party names vs internal and I believe these should all be internal headers? Fixing those and commenting out one of the testcase apps gets it to build. Although there's other issues with not linking kdecore/ui etc properly. Given this code is in heavy development, you may disregard this review request but I'd still like to go though the process. btw, I'm back ;) Diffs ----- scriptengines/qml/common/scriptenv.cpp b79cd3d declarativeimports/core/framesvgitem.h fb4741a scriptengines/qml/declarative/packageaccessmanager.h 3e9a712 scriptengines/qml/declarative/packageaccessmanagerfactory.h 70e4eb9 scriptengines/qml/plasmoid/abstractjsappletscript.h cdd709c scriptengines/qml/plasmoid/appletauthorization.cpp 6fe9454 scriptengines/qml/plasmoid/appletinterface.h 6226802 scriptengines/qml/plasmoid/appletinterface.cpp f5dc187 scriptengines/qml/plasmoid/declarativeappletscript.h 18b324b scriptengines/qml/plasmoid/declarativeappletscript.cpp 75d25eb shell/CMakeLists.txt ecbfad9 Diff: https://git.reviewboard.kde.org/r/108798/diff/ Testing ------- Able to build things, but didn't look into why proper KDE libraries not being linked in yet (editing the generated CMakefiles/component.dir/link.txt works around this for now) Thanks, Shawn Starr --===============2018349722394375675== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/108798/

This change has been discarded.

Review request for Plasma, Aaron J. Seigo and Marco Martin.
By Shawn Starr.

Updated Aug. 31, 2015, 9:17 p.m.

Repository: plasma-framework

Description 

Trying to build plasma-framework I encountered some headers using 3rd party names vs internal and I believe these should all be internal headers? Fixing those and commenting out one of the testcase apps gets it to build. Although there's other issues with not linking kdecore/ui etc properly. Given this code is in heavy development, you may disregard this review request but I'd still like to go though the process.

btw, I'm back ;)

Testing 

Able to build things, but didn't look into why proper KDE libraries not being linked in yet (editing the generated CMakefiles/component.dir/link.txt works around this for now)

Diffs

  • scriptengines/qml/common/scriptenv.cpp (b79cd3d)
  • declarativeimports/core/framesvgitem.h (fb4741a)
  • scriptengines/qml/declarative/packageaccessmanager.h (3e9a712)
  • scriptengines/qml/declarative/packageaccessmanagerfactory.h (70e4eb9)
  • scriptengines/qml/plasmoid/abstractjsappletscript.h (cdd709c)
  • scriptengines/qml/plasmoid/appletauthorization.cpp (6fe9454)
  • scriptengines/qml/plasmoid/appletinterface.h (6226802)
  • scriptengines/qml/plasmoid/appletinterface.cpp (f5dc187)
  • scriptengines/qml/plasmoid/declarativeappletscript.h (18b324b)
  • scriptengines/qml/plasmoid/declarativeappletscript.cpp (75d25eb)
  • shell/CMakeLists.txt (ecbfad9)

View Diff
--===============2018349722394375675==-- --===============1079221895079155865== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============1079221895079155865==--