'Review Request 125006: Add individual monitor for each cpu option for system load viewer'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Review Request 125006: Add individual monitor for each cpu option for system load viewer
From:       Kåre Särs <kare.sars () iki ! fi>
Date:       2015-08-31 20:13:09
Message-ID: 20150831201309.10622.80163 () mimi ! kde ! org
[Download RAW message or body]

--===============0640497374729897136==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125006/
-----------------------------------------------------------

Review request for Plasma, David Edmundson and Martin Yrjölä.

Repository: kdeplasma-addons

Description
-------

When compact-bar monitos are selected the "show: CPUs separately" is enabled. When \
activated every cpu gets it's own monitor. The individual monitors try to fit in the \
space of two bars but when the number of cpus are too high the widht of the cpu \
monitors grow proportionally.

Diffs
-----

  applets/systemloadviewer/package/contents/config/main.xml 0edfd89 
  applets/systemloadviewer/package/contents/ui/GeneralSettings.qml a577b1a 
  applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml cb63fed 

Diff: https://git.reviewboard.kde.org/r/125006/diff/

Testing
-------

Running it on my own computer ;)

Issues:
1) When changing the CPUs separately setting the cpu column(s) size(s) are set to \
minimal and a restart of the applet is needed to get good loking layouts. 2) The \
tooltip does not fit all the cpu rows if the number of cpus are over 4 (6?).

Thanks,

Kåre Särs

--===============0640497374729897136==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/125006/">https://git.reviewboard.kde.org/r/125006/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma, David Edmundson and Martin Yrjölä.</div>
<div>By Kåre Särs.</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeplasma-addons
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">When compact-bar monitos are selected the "show: CPUs \
separately" is enabled. When activated every cpu gets it's own monitor. The \
individual monitors try to fit in the space of two bars but when the number of cpus \
are too high the widht of the cpu monitors grow proportionally.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Running it on my own computer ;)</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Issues: 1) When changing the CPUs separately setting the cpu column(s) \
size(s) are set to minimal and a restart of the applet is needed to get good loking \
layouts. 2) The tooltip does not fit all the cpu rows if the number of cpus are over \
4 (6?).</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/systemloadviewer/package/contents/config/main.xml <span style="color: \
grey">(0edfd89)</span></li>

 <li>applets/systemloadviewer/package/contents/ui/GeneralSettings.qml <span \
style="color: grey">(a577b1a)</span></li>

 <li>applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml <span \
style="color: grey">(cb63fed)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/125006/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============0640497374729897136==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 