--===============3344796400166493986== Content-Type: multipart/alternative; boundary="===============0640497374729897136==" --===============0640497374729897136== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125006/ ----------------------------------------------------------- Review request for Plasma, David Edmundson and Martin Yrjölä. Repository: kdeplasma-addons Description ------- When compact-bar monitos are selected the "show: CPUs separately" is enabled. When activated every cpu gets it's own monitor. The individual monitors try to fit in the space of two bars but when the number of cpus are too high the widht of the cpu monitors grow proportionally. Diffs ----- applets/systemloadviewer/package/contents/config/main.xml 0edfd89 applets/systemloadviewer/package/contents/ui/GeneralSettings.qml a577b1a applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml cb63fed Diff: https://git.reviewboard.kde.org/r/125006/diff/ Testing ------- Running it on my own computer ;) Issues: 1) When changing the CPUs separately setting the cpu column(s) size(s) are set to minimal and a restart of the applet is needed to get good loking layouts. 2) The tooltip does not fit all the cpu rows if the number of cpus are over 4 (6?). Thanks, Kåre Särs --===============0640497374729897136== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125006/

Review request for Plasma, David Edmundson and Martin Yrjölä.
By Kåre Särs.
Repository: kdeplasma-addons

Description 

When compact-bar monitos are selected the "show: CPUs separately" is enabled. When activated every cpu gets it's own monitor. The individual monitors try to fit in the space of two bars but when the number of cpus are too high the widht of the cpu monitors grow proportionally.

Testing 

Running it on my own computer ;)


Issues:
1) When changing the CPUs separately setting the cpu column(s) size(s) are set to minimal and a restart of the applet is needed to get good loking layouts.
2) The tooltip does not fit all the cpu rows if the number of cpus are over 4 (6?).

Diffs

  • applets/systemloadviewer/package/contents/config/main.xml (0edfd89)
  • applets/systemloadviewer/package/contents/ui/GeneralSettings.qml (a577b1a)
  • applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml (cb63fed)

View Diff
--===============0640497374729897136==-- --===============3344796400166493986== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============3344796400166493986==--