[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 124114: Add "Lock Screen" to desktop toolbox
From: "David Edmundson" <david () davidedmundson ! co ! uk>
Date: 2015-08-31 16:29:10
Message-ID: 20150831162910.10622.94251 () mimi ! kde ! org
[Download RAW message or body]
--===============8692737228726974729==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On June 17, 2015, 3:29 a.m., David Edmundson wrote:
> > > This does not check KAuthorized before to hide the entry but neither does the \
> > > context menu.
> >
> > Well that's a bit rubbish.
> > Ship this, but lets remember to fix both, poke me if it gets near release and I \
> > haven't.
> > BTW, is it possible to power this menu from the QActions we have in Plasma, I \
> > haven't looked but it should reduce some code?
>
> Kai Uwe Broulik wrote:
> I don't know, the context menu containment action generates a bunch of QActions as \
> well as the global shortcuts
> Jeremy Whiting wrote:
> Kai, David, Any update on this?
I said "ship it!" If I then procede to ramble with other gibberish, it's only because \
I'm lonely. You can safely ignore it.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124114/#review81518
-----------------------------------------------------------
On June 16, 2015, 8:18 p.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124114/
> -----------------------------------------------------------
>
> (Updated June 16, 2015, 8:18 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> It used to be present in 4.x and makes it consistent with what the context menu \
> provides. This does not check KAuthorized before to hide the entry but neither does \
> the context menu. As suggested in \
> https://forum.kde.org/viewtopic.php?f=289&t=126770
>
> Diffs
> -----
>
> toolboxes/desktoptoolbox/contents/ui/ToolBoxItem.qml c2a36e9
>
> Diff: https://git.reviewboard.kde.org/r/124114/diff/
>
>
> Testing
> -------
>
> Works
>
>
> File Attachments
> ----------------
>
> Lock screen entry
> https://git.reviewboard.kde.org/media/uploaded/files/2015/06/16/1c037bef-4280-4da8-bf9c-7cdc3d0e37b6__lockscreentoolbox.png
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
--===============8692737228726974729==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124114/">https://git.reviewboard.kde.org/r/124114/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On June 17th, 2015, 3:29 a.m. UTC, <b>David \
Edmundson</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><blockquote style="text-rendering: inherit;padding: 0 0 0 \
1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: \
inherit;"> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This does not check KAuthorized before to hide the \
entry but neither does the context menu.</p> </blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Well that's a bit rubbish. Ship this, but lets \
remember to fix both, poke me if it gets near release and I haven't.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">BTW, is it possible to power this menu from the QActions we have in Plasma, \
I haven't looked but it should reduce some code?</p></pre> </blockquote>
<p>On June 17th, 2015, 4:35 p.m. UTC, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
don't know, the context menu containment action generates a bunch of QActions as well \
as the global shortcuts</p></pre> </blockquote>
<p>On August 31st, 2015, 3:26 p.m. UTC, <b>Jeremy Whiting</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Kai, \
David, Any update on this?</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
said "ship it!" If I then procede to ramble with other gibberish, it's only because \
I'm lonely. You can safely ignore it.</p></pre> <br />
<p>- David</p>
<br />
<p>On June 16th, 2015, 8:18 p.m. UTC, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated June 16, 2015, 8:18 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">It used to be present in 4.x and makes it consistent \
with what the context menu provides. This does not check KAuthorized before to hide \
the entry but neither does the context menu. As suggested in \
https://forum.kde.org/viewtopic.php?f=289&t=126770</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Works</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>toolboxes/desktoptoolbox/contents/ui/ToolBoxItem.qml <span style="color: \
grey">(c2a36e9)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124114/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/06/16/1c037bef-4280-4da8-bf9c-7cdc3d0e37b6__lockscreentoolbox.png">Lock \
screen entry</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8692737228726974729==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic