--===============5139859269729005711== Content-Type: multipart/alternative; boundary="===============8692737228726974729==" --===============8692737228726974729== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On June 17, 2015, 3:29 a.m., David Edmundson wrote: > > > This does not check KAuthorized before to hide the entry but neither does the context menu. > > > > Well that's a bit rubbish. > > Ship this, but lets remember to fix both, poke me if it gets near release and I haven't. > > > > BTW, is it possible to power this menu from the QActions we have in Plasma, I haven't looked but it should reduce some code? > > Kai Uwe Broulik wrote: > I don't know, the context menu containment action generates a bunch of QActions as well as the global shortcuts > > Jeremy Whiting wrote: > Kai, David, Any update on this? I said "ship it!" If I then procede to ramble with other gibberish, it's only because I'm lonely. You can safely ignore it. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124114/#review81518 ----------------------------------------------------------- On June 16, 2015, 8:18 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124114/ > ----------------------------------------------------------- > > (Updated June 16, 2015, 8:18 p.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > ------- > > It used to be present in 4.x and makes it consistent with what the context menu provides. This does not check KAuthorized before to hide the entry but neither does the context menu. As suggested in https://forum.kde.org/viewtopic.php?f=289&t=126770 > > > Diffs > ----- > > toolboxes/desktoptoolbox/contents/ui/ToolBoxItem.qml c2a36e9 > > Diff: https://git.reviewboard.kde.org/r/124114/diff/ > > > Testing > ------- > > Works > > > File Attachments > ---------------- > > Lock screen entry > https://git.reviewboard.kde.org/media/uploaded/files/2015/06/16/1c037bef-4280-4da8-bf9c-7cdc3d0e37b6__lockscreentoolbox.png > > > Thanks, > > Kai Uwe Broulik > > --===============8692737228726974729== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124114/

On June 17th, 2015, 3:29 a.m. UTC, David Edmundson wrote:

This does not check KAuthorized before to hide the entry but neither does the context menu.

Well that's a bit rubbish. Ship this, but lets remember to fix both, poke me if it gets near release and I haven't.

BTW, is it possible to power this menu from the QActions we have in Plasma, I haven't looked but it should reduce some code?

On June 17th, 2015, 4:35 p.m. UTC, Kai Uwe Broulik wrote:

I don't know, the context menu containment action generates a bunch of QActions as well as the global shortcuts

On August 31st, 2015, 3:26 p.m. UTC, Jeremy Whiting wrote:

Kai, David, Any update on this?

I said "ship it!" If I then procede to ramble with other gibberish, it's only because I'm lonely. You can safely ignore it.

- David

On June 16th, 2015, 8:18 p.m. UTC, Kai Uwe Broulik wrote:

Review request for Plasma.

By Kai Uwe Broulik.

Updated June 16, 2015, 8:18 p.m.

Repository: plasma-desktop

Description

It used to be present in 4.x and makes it consistent with what the context menu provides. This does not check KAuthorized before to hide the entry but neither does the context menu. As suggested in https://forum.kde.org/viewtopic.php?f=289&t=126770

Testing

Works

Diffs

toolboxes/desktoptoolbox/contents/ui/ToolBoxItem.qml (c2a36e9)

File Attachments

Lock screen entry

--===============8692737228726974729==-- --===============5139859269729005711== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============5139859269729005711==--