'Re: Review Request 124947: [screenlocker] Share QQmlEngine between all views in the greeter'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 124947: [screenlocker] Share QQmlEngine between all views in the greeter
From:       Martin_Gräßlin <mgraesslin () kde ! org>
Date:       2015-08-31 12:16:07
Message-ID: 20150831121607.8333.24566 () mimi ! kde ! org
[Download RAW message or body]

--===============3271174662871752142==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124947/
-----------------------------------------------------------

(Updated Aug. 31, 2015, 12:16 p.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma and David Edmundson.

Changes
-------

Submitted with commit 7e1a4df817bdd156352ac9b37eac01837ed25204 by Martin Gräßlin to branch \
master.

Repository: plasma-workspace

Description
-------

In a multi-screen setup we have multiple views showing the same Qml
scene. Let's share the engine for all views.

Diffs
-----

  ksmserver/screenlocker/greeter/CMakeLists.txt 4fb679f838a80f11eb8e4b4f5cb5ef04dc39c0f7 
  ksmserver/screenlocker/greeter/greeterapp.h ed278e492a9a237f65f4c1600360f84fb25bdad7 
  ksmserver/screenlocker/greeter/greeterapp.cpp b500ba44c2b483d7372ca46840152c90ef5f798c 

Diff: https://git.reviewboard.kde.org/r/124947/diff/

Testing
-------

This makes creating a second view basically free (from timing perspective)

Thanks,

Martin Gräßlin

--===============3271174662871752142==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/124947/">https://git.reviewboard.kde.org/r/124947/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px \
#888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma and David Edmundson.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated Aug. 31, 2015, 12:16 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Submitted with commit \
7e1a4df817bdd156352ac9b37eac01837ed25204 by Martin Gräßlin to branch master.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In a multi-screen \
setup we have multiple views showing the same Qml scene. Let&#39;s share the engine for all \
views.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This makes \
creating a second view basically free (from timing perspective)</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>ksmserver/screenlocker/greeter/CMakeLists.txt <span style="color: \
grey">(4fb679f838a80f11eb8e4b4f5cb5ef04dc39c0f7)</span></li>

 <li>ksmserver/screenlocker/greeter/greeterapp.h <span style="color: \
grey">(ed278e492a9a237f65f4c1600360f84fb25bdad7)</span></li>

 <li>ksmserver/screenlocker/greeter/greeterapp.cpp <span style="color: \
grey">(b500ba44c2b483d7372ca46840152c90ef5f798c)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/124947/diff/" style="margin-left: 3em;">View \
Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============3271174662871752142==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 