From kde-panel-devel Mon Aug 31 12:16:07 2015 From: =?utf-8?q?Martin_Gr=C3=A4=C3=9Flin?= Date: Mon, 31 Aug 2015 12:16:07 +0000 To: kde-panel-devel Subject: Re: Review Request 124947: [screenlocker] Share QQmlEngine between all views in the greeter Message-Id: <20150831121607.8333.24566 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=144102341225784 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============2173087681395801390==" --===============2173087681395801390== Content-Type: multipart/alternative; boundary="===============3271174662871752142==" --===============3271174662871752142== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124947/ ----------------------------------------------------------- (Updated Aug. 31, 2015, 12:16 p.m.) Status ------ This change has been marked as submitted. Review request for Plasma and David Edmundson. Changes ------- Submitted with commit 7e1a4df817bdd156352ac9b37eac01837ed25204 by Martin Gräßlin to branch master. Repository: plasma-workspace Description ------- In a multi-screen setup we have multiple views showing the same Qml scene. Let's share the engine for all views. Diffs ----- ksmserver/screenlocker/greeter/CMakeLists.txt 4fb679f838a80f11eb8e4b4f5cb5ef04dc39c0f7 ksmserver/screenlocker/greeter/greeterapp.h ed278e492a9a237f65f4c1600360f84fb25bdad7 ksmserver/screenlocker/greeter/greeterapp.cpp b500ba44c2b483d7372ca46840152c90ef5f798c Diff: https://git.reviewboard.kde.org/r/124947/diff/ Testing ------- This makes creating a second view basically free (from timing perspective) Thanks, Martin Gräßlin --===============3271174662871752142== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124947/

This change has been marked as submitted.

Review request for Plasma and David Edmundson.
By Martin Gräßlin.

Updated Aug. 31, 2015, 12:16 p.m.

Changes

Submitted with commit 7e1a4df817bdd156352ac9b37eac01837ed25204 by Martin Gräßlin to branch master.
Repository: plasma-workspace

Description 

In a multi-screen setup we have multiple views showing the same Qml
scene. Let's share the engine for all views.

Testing 

This makes creating a second view basically free (from timing perspective)

Diffs

  • ksmserver/screenlocker/greeter/CMakeLists.txt (4fb679f838a80f11eb8e4b4f5cb5ef04dc39c0f7)
  • ksmserver/screenlocker/greeter/greeterapp.h (ed278e492a9a237f65f4c1600360f84fb25bdad7)
  • ksmserver/screenlocker/greeter/greeterapp.cpp (b500ba44c2b483d7372ca46840152c90ef5f798c)

View Diff
--===============3271174662871752142==-- --===============2173087681395801390== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============2173087681395801390==--